feat(S3): add SSE-C support in S3 External Storage #50514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just need to add the parameter and fix two calls. All other logic is already implemented and implicitly called through the S3ConnectionTrait fixes #33283 Signed-off-by: Christian Becker <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
Co-authored-by: Christian Becker <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added
3. to review
4 tasks
Member
Author
|
/backport f1c025d to stable31 |
Member
Author
|
/backport f1c025d to stable30 |
Member
Author
|
/backport f1c025d to stable29 |
4 tasks
juliusknorr
approved these changes
Jan 29, 2025
artonge
approved these changes
Jan 29, 2025
This was referenced Jan 29, 2025
Member
Author
|
/backport c25c5bb to stable31 |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing bits to support SSE-C in S3 external storage.
Just need to add the parameter and fix two calls. All other logic is already implemented and implicitly called through the S3ConnectionTrait
Documentation PR: nextcloud/documentation#12530
Checklist
before:
after:
