Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 21, 2025

Bumps nextcloud/coding-standard from 1.3.2 to 1.4.0.

Release notes

Sourced from nextcloud/coding-standard's releases.

v1.4.0

What's Changed

New Contributors

Full Changelog: nextcloud/coding-standard@v1.3.2...v1.4.0

Changelog

Sourced from nextcloud/coding-standard's changelog.

1.4.0 — 2025-07-19

Added

  • no_whitespace_in_blank_line: Remove trailing whitespace at the end of blank lines
  • operator_linebreak: Split conditional statements into multiple lines and place operator at the beginning
Commits
  • 8e06808 Merge pull request #46 from nextcloud/prepare-next-release
  • 9c2e3d2 chore: update changelog
  • 1f03ece Merge pull request #45 from nextcloud/bug/no-space-blank-line
  • 039e6e8 ci: update workflows
  • f04a128 style: enforce no_whitespace_in_blank_line
  • af952f4 Merge pull request #44 from nextcloud/suggest-as-dev-package
  • 213d422 chore: suggest package as dev dependency
  • e2a9dbe Merge pull request #43 from nextcloud/fix/noid/platform
  • 3f348ea build(deps): drop PHP 7.x for incompatiblity
  • 7b16bcf Merge pull request #40 from nextcloud/enh/operator_linebreak
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner June 21, 2025 01:51
@dependabot dependabot bot added the 3. to review Waiting for reviews label Jun 21, 2025
@dependabot dependabot bot requested review from artonge and removed request for a team June 21, 2025 01:51
@dependabot dependabot bot requested review from come-nc and yemkareems June 21, 2025 01:51
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 21, 2025

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update .git-blame-ignore-revs with your commit sha to ignore then automated style fixes from blame

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doublechecked with difftastic, only style changes.

@come-nc come-nc enabled auto-merge June 23, 2025 08:30
@come-nc
Copy link
Contributor

come-nc commented Jun 23, 2025

There is a diff in the php-cs CI check that I do not get locally 🤷

@kesselb kesselb force-pushed the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch from 2eee7c4 to 1425f70 Compare June 23, 2025 13:32
@come-nc come-nc force-pushed the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch from 1425f70 to fdbc3c0 Compare June 24, 2025 14:03
@susnux susnux force-pushed the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch from fdbc3c0 to 4b85dca Compare June 30, 2025 13:09
Comment on lines 100 to 101
'users'
=> [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a bit weird and should rather be:

					'users' => [

Copy link
Contributor

@kesselb kesselb Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed them manually

@kesselb kesselb force-pushed the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch from 4b85dca to 4039b88 Compare July 1, 2025 12:06
@kesselb
Copy link
Contributor

kesselb commented Jul 1, 2025

@kesselb kesselb force-pushed the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch from 4039b88 to ae55bf4 Compare July 1, 2025 12:13
dependabot bot and others added 3 commits July 1, 2025 16:24
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.2 to 1.4.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](nextcloud/coding-standard@v1.3.2...v1.4.0)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-version: 1.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
@kesselb kesselb force-pushed the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch from ae55bf4 to 9b1a306 Compare July 1, 2025 14:27
@nickvergessen nickvergessen disabled auto-merge July 1, 2025 14:45
@nickvergessen nickvergessen merged commit 214c304 into master Jul 1, 2025
190 of 193 checks passed
@nickvergessen nickvergessen deleted the dependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.4.0 branch July 1, 2025 14:45
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants