fix(nullcache): make get compliant with the interface #53678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
approved these changes
Jun 25, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just one of those cases where null/false were badly mixed in legacy code.
AndyScherzinger
changed the title
The interface defines ICacheEntry|false, thus we should not return null. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
debt/noid/wrong-return-type-nullcache
branch
from
ea4250b to
53fb05e
Compare
skjnldsv
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code style update in pull request #53625 appears to trigger a Psalm warning about NullCache returning null, which makes it non-compliant with the interface. This seems like a valid finding; however, I am not familiar with this part, and a thorough review should be done.
Checklist