Skip to content

Conversation

@tsterbak
Copy link
Member

@tsterbak tsterbak commented Nov 1, 2023

This PR adds:

Supported devices:

  • OnePlus 3/3T (oneplus3) (thanks to @SirRGB)
  • Redmi 9 Poco M2 (lancelot) (thanks to @anon1892)

Fixes:

  • Bug where installer crashes when sideloading progress goes over 100%
  • Properly handle exceptions while processing the ROM zip file (File is not a zip file, file is a zip file but does not contain metadata file) (thanks to @anon1892)

@tsterbak tsterbak marked this pull request as ready for review November 1, 2023 16:13
SirRGB and others added 23 commits November 21, 2023 23:29
* capitalization matters
* changes untested
* partially fixes #352
Should partially fix
#352
* taken from the lineage wiki and https://telegra.ph/G5-Variants--Code-Names-10-07

Signed-off-by: SirRGB <[email protected]>
* taken from gsmarena, wikipedia and the lineage wiki
* taken from the lineage wiki

Signed-off-by: SirRGB <[email protected]>
* missed when updating xda links.

Signed-off-by: SirRGB <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.0.6...2.0.7)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@MagicLike MagicLike added the enhancement New feature or request label Dec 1, 2023
tsterbak and others added 16 commits December 10, 2023 18:54
This PR mainly addresses #394 and #354.

It also adds:
- improved Makefile
Related to #416, but don't explain it.
This PR just handle a system image as invalid instead of crashing when :
- File is not a zip file (so like #416 )
- File is a zip file but does not contain metadata file

For now, only `IMG-e-1.18-t-20231207360613-stable-FP5.zip` is known to
be in the second case, and it's a very strange installation package, OAI
cannot handle that for now (related to #288 ?), so the file is shown as
invalid.
Maybe we can explain it with more details to the user?
@tsterbak tsterbak requested review from a user and MagicLike January 15, 2024 17:36
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else, look good to me

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work with Python 3.11?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should. Haven't tried it so far. Still happy with 3.10 :D

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm already on 3.11, and I had to do aa6fa9c to be able to install all dependencies, otherwise OAI wouldn't work...

Now the right size of the installer scales with the screen when
resizing.
@tsterbak tsterbak merged commit 479fba6 into main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants