Skip to content

Fix IngressSettings support#827

Merged
joehan merged 2 commits into
firebase:masterfrom
takaaa220:fix-ingress-settings
Jan 19, 2021
Merged

Fix IngressSettings support#827
joehan merged 2 commits into
firebase:masterfrom
takaaa220:fix-ingress-settings

Conversation

@takaaa220

@takaaa220 takaaa220 commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

#815 PR has been merged and released to support IngressSettings.
However, as I commented on #808 (comment), it doesn't seem to work properly, so I fixed it.

My related PR in firebase-tools is firebase/firebase-tools#2924

Thanks!

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla

google-cla Bot commented Dec 12, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@takaaa220

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla

google-cla Bot commented Dec 12, 2020

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@takaaa220 takaaa220 changed the title Fix IngressSettings Fix IngressSettings support Dec 12, 2020
@samtstern samtstern requested a review from joehan December 17, 2020 13:57
@samtstern

Copy link
Copy Markdown
Contributor

Thanks for this contribution! @joehan can you take a look at this PR as well as firebase/firebase-tools#2924 ?

@joehan joehan merged commit 5f64797 into firebase:master Jan 19, 2021
joehan added a commit that referenced this pull request Jan 19, 2021
samtstern pushed a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants