Skip to content

Add ingress settings support in firebase functions#2924

Merged
joehan merged 4 commits into
firebase:masterfrom
takaaa220:add-ingress-settings-support-in-firebase-functions
Jan 12, 2021
Merged

Add ingress settings support in firebase functions#2924
joehan merged 4 commits into
firebase:masterfrom
takaaa220:add-ingress-settings-support-in-firebase-functions

Conversation

@takaaa220

Copy link
Copy Markdown
Contributor

Description

Supports firebase-functions SDK in firebase/firebase-functions#815 and firebase/firebase-functions#827

functions
  .runWith({
    ingressSettings: "ONLY_INTERNAL_ONLY",
  })
  .https.onRequest(() => {
  ...
  });

Scenarios Tested

I've created a new cloud function with specific ingressSettings and it works! and, I updated its function and it also works!

Sample Commands

No change in cli.

@google-cla google-cla Bot added the cla: yes Manual indication that this has passed CLA. label Dec 12, 2020
@samtstern samtstern requested a review from joehan December 17, 2020 13:59
@samtstern

Copy link
Copy Markdown
Contributor

@takaaa220 thanks for this contribution! Hopefully @joehan can take a look at firebase/firebase-functions#827 first and then review this one.

@takaaa220

takaaa220 commented Dec 24, 2020

Copy link
Copy Markdown
Contributor Author

@joehan
Thank your for reviewing. I will resolve conflicts this week 🙇

@coveralls

coveralls commented Jan 12, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 65.558% when pulling 93f986b on takaaa220:add-ingress-settings-support-in-firebase-functions into 67cff84 on firebase:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants