bpo-41546: make pprint (like print) not write to stdout when it is None#26810
Merged
iritkatriel merged 7 commits intopython:mainfrom Jul 19, 2021
Merged
bpo-41546: make pprint (like print) not write to stdout when it is None#26810iritkatriel merged 7 commits intopython:mainfrom
iritkatriel merged 7 commits intopython:mainfrom
Conversation
iritkatriel
changed the title
eryksun
reviewed
Jun 20, 2021
Member
Author
|
Any more comments before I merge? |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please document the change.
Lib/test/test_pprint.py
Outdated
Comment on lines
252
to
254
Member
There was a problem hiding this comment.
Is not it already tested in test_stdout_is_None?
Member
Author
There was a problem hiding this comment.
You're right, this is no longer needed, I'll remove. With my first (more complex) solution this covered more code paths.
Member
|
Please document this behavior in the module documentation and add the versionchanged directive. |
Member
Author
Done. Probably not part of this PR, but I don't think the doc needs to repeat this twice. Could we not refer from pprint()'s doc to PrettyPrinter.pprint()'s doc? |
Member
|
Why not in this PR? |
Member
Author
Sure, if you don't mind mixing two celebrations. |
…es for shared parameters.
Member
Author
@serhiy-storchaka I've made the doc change, let me know if it looks ok. |
serhiy-storchaka
approved these changes
Jul 18, 2021
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
merwok
reviewed
Jul 19, 2021
| Added the *sort_dicts* parameter. | ||
|
|
||
| .. versionchanged:: 3.10 | ||
| Added the *underscore_numbers* parameter. |
Member
There was a problem hiding this comment.
Why remove versionchanged notes? People need to know this.
Member
Author
There was a problem hiding this comment.
We're removing the repetitions.
Member
There was a problem hiding this comment.
But these are not needless repetitions: they are separate notes on separate functions.
Member
Author
There was a problem hiding this comment.
We removed repetition not only of the version labels but also of the definitions they relate to, and we replaced them by a reference to where those definitions appear (once).
It is easier read the docs when they are not repetitive because then you know that A is the same as B, and you don't need to do the work to compare them just to find that out.
|
Member
Author
|
The build failure seems unrelated to this change: |
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Jul 20, 2021
* origin/main: (1146 commits) bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155) bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249) correct spelling (pythonGH-27076) bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237) bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797) Clean up comma usage in Doc/library/functions.rst (python#27083) bpo-42238: Fix small rst issue in NEWS.d/. (python#27238) bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091) bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231) bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206) bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216) bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810) bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992) bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402) bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032) bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278) bpo-44654: Do not export the union type related symbols (pythonGH-27223) bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218) bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196) bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41546