Skip to content

bpo-44340: Add support for building with clang full/thin lto#27231

Merged
corona10 merged 5 commits intopython:mainfrom
corona10:bpo-44340
Jul 19, 2021
Merged

bpo-44340: Add support for building with clang full/thin lto#27231
corona10 merged 5 commits intopython:mainfrom
corona10:bpo-44340

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jul 18, 2021 •
edited by bedevere-bot
Loading

@corona10 corona10 requested review from ned-deily and pablogsal July 18, 2021 16:11
@corona10 corona10 changed the title bpo-44340: Add support for building with clang full/thin lto [DRAFT] bpo-44340: Add support for building with clang full/thin lto Jul 18, 2021
@pablogsal
Copy link
Member

pablogsal commented Jul 18, 2021

Make sure you use @tiran solution for regenerating autoconf or otherwise is going to cause some incompatibilities (https://bugs.python.org/issue44035)

@corona10
Copy link
Member Author

corona10 commented Jul 18, 2021

Make sure you use @tiran solution for regenerating autoconf or otherwise is going to cause some incompatibilities

Thanks, I will check it out

@corona10
Copy link
Member Author

corona10 commented Jul 18, 2021

@pablogsal cc @tiran
Okay, it perfectly works :)

@corona10 corona10 mentioned this pull request Jul 18, 2021
Closed
corona10
corona10 commented Jul 18, 2021
View reviewed changes
configure.ac Outdated
Copy link
Member Author

@corona10 corona10 Jul 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Py_LTO_POLICY is the default, it will follow the default LTO option of compiler

@corona10
Copy link
Member Author

corona10 commented Jul 18, 2021

cc @holmanb

corona10
corona10 commented Jul 18, 2021
View reviewed changes
@gpshead
Copy link
Member

gpshead commented Jul 18, 2021

I believe you pushed a bunch of unrelated commits to the branch.

@corona10 corona10 changed the title [DRAFT] bpo-44340: Add support for building with clang full/thin lto bpo-44340: Add support for building with clang full/thin lto Jul 18, 2021
@corona10
Copy link
Member Author

corona10 commented Jul 18, 2021

I believe you pushed a bunch of unrelated commits to the branch.

Thanks, I make a lot of people noise ;)
I've rebased the PR.

corona10
corona10 commented Jul 19, 2021
View reviewed changes
Copy link
Member Author

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now waiting for @pablogsal 's review who is the release manager of Python 3.11 :)

pablogsal
pablogsal approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @corona10 and @holmanb !

@corona10 corona10 merged commit b2cf251 into python:main Jul 19, 2021
@corona10 corona10 deleted the bpo-44340 branch July 19, 2021 10:53
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
56e8889 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@pablogsal pablogsal pablogsal approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

+1 more reviewer

@holmanb holmanb holmanb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @pablogsal @gpshead @holmanb @the-knights-who-say-ni @bedevere-bot