bpo-28814: Undeprecate inadvertantly deprecated inspect function.#122
bpo-28814: Undeprecate inadvertantly deprecated inspect function.#122berkerpeksag merged 1 commit intopython:masterfrom
Conversation
I did not touch the code but I'll be happy to move these 2 functions into the "stack frame extraction" section of |
Doc/whatsnew/3.5.rst
Outdated
There was a problem hiding this comment.
Accidentally doubled word here: s/with with/with/
|
Thanks! This mostly looks good to me, just one accidentally doubled word to fix before it can be merged. |
Doc/library/inspect.rst
Outdated
There was a problem hiding this comment.
"Ignore previous deprecation notice." is superfluous and can be deleted in my opinion.
Doc/whatsnew/3.5.rst
Outdated
There was a problem hiding this comment.
Indentation should use 3 or 4 spaces:
.. note::
Functions [...]There was a problem hiding this comment.
Or start with:
:func:`~inspect.getargvalues` and :func:`~inspect.formatargvalues` functions were inadvertently [...]I'm not a native speaker so I hope @ncoghlan will chime in here :)
Doc/whatsnew/3.5.rst
Outdated
There was a problem hiding this comment.
typo: inadvertantly -> inadvertently
There was a problem hiding this comment.
Please add a dot at the end of the sentence.
|
Thanks ! Comments addressed. |
berkerpeksag
left a comment
berkerpeksag
left a comment
There was a problem hiding this comment.
Looks pretty good to me, just left two minor comments :)
Doc/whatsnew/3.5.rst
Outdated
There was a problem hiding this comment.
You forgot to end the sentence with a full stop :)
Doc/whatsnew/3.5.rst
Outdated
There was a problem hiding this comment.
Looking at this again, I think using a note directive is not needed in 3.5 whatsnew page.
There was a problem hiding this comment.
Do you mean removing the .. note:: altogether along with the text, or just demote the text to a plain paragraph ?
There was a problem hiding this comment.
Sorry, I wasn't clear in my earlier comment. I meant the latter one.
There was a problem hiding this comment.
Ok, Done. And full stop added at the end.
Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation So un-deprecate in the doc, and leave a note to ignore previous deprecation notice.
|
Thanks! |
Thanks as well. |
…ython#122) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
…ython#122) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
|
@berkerpeksag Thanks, you picked up several things I missed :) |
) (#243) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
) (#244) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)
The cache caused false block leak errors from test suite --huntrleaks / -R runs. The performance penalty is irrelevant in debug builds. https://bitbucket.org/stackless-dev/stackless/issues/122
4 participants
Nick Coghlan said on bpo-28814:
So un-deprecate in the doc, and leave a note to ignore previous
deprecation notice.