[3.6] bpo-28814: Undeprecate inadvertently deprecated inspect functions. (#122)

[berkerpeksag]

Nick Coghlan said on bpo-28814:

inspect.getargvalues() and inspect.formatargvalues() were deprecated
in Python 3.5 as part of implementing bpo-20438

This is incorrect, as these are frame introspection related functions,
not callable introspection ones. The documentation and implementation
layout is confusing though, as they're interleaved with the callable
introspection operation

This commit undeprecates these functions and adds a note to ignore
previous deprecation notices.

(cherry picked from commit 0899b98)

[1st1]

I'd like to keep a note that inspect.signature API is superior and is recommended to use instead of inspect.getargspec.

[berkerpeksag]

Hi @1st1, I agree but can we add it in a separate pull request? This is a backport PR and I'd like to keep this commit as a cherry-pick of 0899b98 :)

[1st1]

Sure. Would you be able to create a new PR for that? Or I can do it.

[berkerpeksag]

If you have some spare time this week, that would be great! Otherwise, I will do it next week and ping you to get a review.

[Carreau]

I'd like to keep a note that inspect.signature API is superior and is recommended to use instead of inspect.getargspec.

I'm confused, I did not remove such statement and it is already in inspect.rst:

.. deprecated:: 3.0
      Use :func:`getfullargspec` for an updated API that is usually a drop-in
      replacement, but also correctly handles function annotations and
      keyword-only parameters.

      Alternatively, use :func:`signature` and
      :ref:`Signature Object <inspect-signature-object>`, which provide a
      more structured introspection API for callables.

getargspec also emit a deprecation warning that point to signature() I can try to do a PR if I better understand what you meant.

[ncoghlan]

@1st1 As @Carreau notes, these PRs aren't about the function introspection APIs (which are covered by http://bugs.python.org/issue27172 ). Rather, they're about http://bugs.python.org/issue28814, which covers a couple of frame introspection APIs that were inadvertently caught up in those deprecations because they're mixed in with the function introspection ones.