Remove clippy plugin#4714

msizanoen1 · 2019-10-22T06:03:35Z

This PR removes the clippy plugin, which is already deprecated and is causing the fmt_macros not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface

flip1995 · 2019-10-22T07:25:00Z

This won't remove the fmt_macros dependence? Also we didn't decide on how / when to remove the Clippy plugin interface. I think just nuking it is ok though, since the warning existed for a long time. cc #2783

ping @rust-lang/clippy thoughts on this?

flip1995 · 2019-10-22T07:26:29Z

Maybe this is better done in combination with #4650

msizanoen1 · 2019-10-22T08:51:31Z

The error happens because clippy_lints was compiled for the host but fmt_macros is only available for the target. Plugins are compiled for the host so removing the plugin should fix the error.
The error is about cross compilation.

flip1995 · 2019-10-22T09:37:02Z

Ah ok, thanks for the clarification!

Manishearth · 2019-10-22T11:01:42Z

We should definitely just remove it, yeah

phansch

Maybe we should write a short announcement about removing this on inside-rust? With clear migration instructions, etc..

Apart from that I think we should finally remove this.

flip1995 · 2019-10-24T09:10:25Z

I opened rust-lang/blog.rust-lang.org#435 for this. Feedback welcome.

bors · 2019-10-24T13:39:18Z

☔ The latest upstream changes (presumably #4650) made this pull request unmergeable. Please resolve the merge conflicts.

msizanoen1 · 2019-11-01T10:32:05Z

Now with rust-lang/rust#65698 merged, this PR is the only remaining roadblock for rust-lang/rust#62558

Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes #4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints. ![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes #4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints. ![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png) changelog: Show deprecated lints in lint documentation again

Manishearth · 2019-11-04T19:13:09Z

@bors r+

https://blog.rust-lang.org/inside-rust/2019/11/04/Clippy-removes-plugin-interface.html

bors · 2019-11-04T19:13:10Z

📌 Commit a127e14 has been approved by Manishearth

bors · 2019-11-04T19:13:17Z

⌛ Testing commit a127e14 with merge 13578b5...

Remove clippy plugin This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

bors · 2019-11-04T19:15:25Z

💔 Test failed - checks-travis

Manishearth · 2019-11-04T19:16:39Z

@bors r+ retry

bors · 2019-11-04T19:16:40Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors · 2019-11-04T19:16:41Z

📌 Commit a127e14 has been approved by Manishearth

bors · 2019-11-04T19:16:48Z

⌛ Testing commit a127e14 with merge f14037b...

Remove clippy plugin This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment) changelog: remove plugin interface

bors · 2019-11-04T19:37:19Z

💔 Test failed - checks-travis

Manishearth · 2019-11-04T19:41:48Z

#4770

tesuji · 2019-11-06T03:19:58Z

This can be merged.
@bors r=Manishearth

bors · 2019-11-06T03:19:59Z

@lzutao: 🔑 Insufficient privileges: Not in reviewers

Manishearth · 2019-11-06T03:20:51Z

@bors r+

bors · 2019-11-06T03:20:53Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors · 2019-11-06T03:20:54Z

📌 Commit a127e14 has been approved by Manishearth

Remove clippy plugin This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment) changelog: remove plugin interface

bors · 2019-11-06T03:21:11Z

⌛ Testing commit a127e14 with merge eae7b99...

bors · 2019-11-06T03:46:53Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing eae7b99 to master...

Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes rust-lang#4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints. ![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png) changelog: Show deprecated lints in lint documentation again

Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes #4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints. ![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png) changelog: Show deprecated lints in lint documentation again

flip1995 added S-needs-discussion Status: Needs further discussion before merging or work can be started S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 22, 2019

Manishearth approved these changes Oct 22, 2019

View reviewed changes

flip1995 approved these changes Oct 22, 2019

View reviewed changes

tesuji mentioned this pull request Oct 22, 2019

generate stderr file on 32bit pointer system #4690

Merged

msizanoen1 force-pushed the remove-plugin branch from 2cacd17 to 592effc Compare October 24, 2019 05:19

phansch approved these changes Oct 24, 2019

View reviewed changes

flip1995 mentioned this pull request Oct 24, 2019

Blog post on removing the Clippy plugin interface rust-lang/blog.rust-lang.org#435

Merged

msizanoen1 mentioned this pull request Oct 24, 2019

Dual proc macro hash rust-lang/rust#65698

Merged

Remove clippy plugin

a127e14

msizanoen1 force-pushed the remove-plugin branch from 592effc to a127e14 Compare October 24, 2019 14:12

evanjs mentioned this pull request Oct 31, 2019

Fix Deprecated lints don't expand #4757

Merged

msizanoen1 mentioned this pull request Nov 1, 2019

Tools are not available on cross compiled platforms since #61861 rust-lang/rust#62558

Closed

mati865 mentioned this pull request Nov 5, 2019

Prevent building the clippy plugin in rustbuild rust-lang/rust#66052

Closed

bors merged commit a127e14 into rust-lang:master Nov 6, 2019

msizanoen1 deleted the remove-plugin branch November 6, 2019 05:13

msizanoen1 mentioned this pull request Nov 6, 2019

Update clippy rust-lang/rust#66142

Closed

msizanoen1 mentioned this pull request Nov 8, 2019

Update clippy rust-lang/rust#66207

Merged

Conversation

msizanoen1 commented Oct 22, 2019 • edited by Manishearth Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flip1995 commented Oct 22, 2019

Uh oh!

flip1995 commented Oct 22, 2019

Uh oh!

msizanoen1 commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flip1995 commented Oct 22, 2019

Uh oh!

Manishearth commented Oct 22, 2019

Uh oh!

phansch left a comment

Choose a reason for hiding this comment

Uh oh!

flip1995 commented Oct 24, 2019

Uh oh!

bors commented Oct 24, 2019

Uh oh!

msizanoen1 commented Nov 1, 2019

Uh oh!

Manishearth commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

Manishearth commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

bors commented Nov 4, 2019

Uh oh!

Manishearth commented Nov 4, 2019

Uh oh!

tesuji commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

Manishearth commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

msizanoen1 commented Oct 22, 2019 •

edited by Manishearth

Loading

msizanoen1 commented Oct 22, 2019 •

edited

Loading