Fix Deprecated lints don't expand#4757
Merged
bors merged 4 commits intorust-lang:masterfrom Nov 7, 2019
Merged
Conversation
- Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py
Contributor
Author
|
Thanks! Didn't even think about the indents. Derp. Some of the doc-comments now barely exceed 80 characters, but I wasn't sure of any line-break conventions, so I left those alone. |
Contributor
Author
|
Pardon the noise. That's what I get for having multiple Checked against the live site and all the lints seem to be present and expandable. |
Contributor
|
@bors r+ thanks! |
Contributor
|
📌 Commit 8ca9c23 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Nov 3, 2019
Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes #4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints. 
Contributor
|
💔 Test failed - checks-travis |
Contributor
|
@bors retry (amended the PR post with a changelog) |
Contributor
bors
added a commit
that referenced
this pull request
Nov 3, 2019
Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes #4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.  changelog: Show deprecated lints in lint documentation again
Contributor
|
💔 Test failed - checks-travis |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 7, 2019
Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes rust-lang#4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.  changelog: Show deprecated lints in lint documentation again
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 7, 2019
Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes rust-lang#4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.  changelog: Show deprecated lints in lint documentation again
Contributor
bors
added a commit
that referenced
this pull request
Nov 7, 2019
Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes #4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.  changelog: Show deprecated lints in lint documentation again
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py
fixes #4748
Unable to
cargo testlocally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.changelog: Show deprecated lints in lint documentation again