rustdoc: simplify mobile item-table CSS#103855
Conversation
Using flexbox in column direction is needlessly complicated, since no special flex powers are being used here. Just use regular block layout. This should result in no visible changes.
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
When I checked locally, it's changing the display. Before your changes:
After your changes:
It also mean that we should add a GUI test to ensure it's displayed like this. |
|
There already is one. https://github.com/rust-lang/rust/blob/master/src/test/rustdoc-gui/label-next-to-symbol.goml#L41 Which browser are you using, and what screen size exactly? |
|
Strange. I used a width of 658px on chrome on macOS. |
|
@GuillaumeGomez I don't have access to a Mac, and when I try to do it in Chrome on Linux, I don't experience the bug. Can you check what the calculated style of the item-table, -row, and -left and -right are in the Developer Tools? |
|
Fixed the issue by... hard reloading the page and changing the style again. Sorry about that. Looks all good! @bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#103275 (Update tinystr) - rust-lang#103703 (Gate some parser recovery behind the check) - rust-lang#103774 (Format `dyn Trait` better in `type_name` intrinsic) - rust-lang#103807 (Add tracking issue for `string_extend_from_within`) - rust-lang#103855 (rustdoc: simplify mobile item-table CSS) - rust-lang#103862 (Use `ObligationCtxt` in `fully_normalize`) - rust-lang#103864 (Reorder `walk_` functions in intravisit.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
5 participants
Using flexbox in column direction is needlessly complicated, since no special flex powers are being used here. Just use regular block layout.
This should result in no visible changes.