Reorder walk_ functions in intravisit.rs#103864
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 2, 2022
Merged
Conversation
Member
Looks good to me. @bors r+ |
Collaborator
Member
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#103275 (Update tinystr) - rust-lang#103703 (Gate some parser recovery behind the check) - rust-lang#103774 (Format `dyn Trait` better in `type_name` intrinsic) - rust-lang#103807 (Add tracking issue for `string_extend_from_within`) - rust-lang#103855 (rustdoc: simplify mobile item-table CSS) - rust-lang#103862 (Use `ObligationCtxt` in `fully_normalize`) - rust-lang#103864 (Reorder `walk_` functions in intravisit.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder the
walk_functions to match the order of thevisit_methods. This is a follow up to #103692.Note that there are some oddballs. I put them where I thought made the most sense:
Also, as some weak evidence that i did things correctly, I get the following before and after the change:
$ sort compiler/rustc_hir/src/intravisit.rs | openssl sha256 SHA256(stdin)= cac13d2545731ef442f318e2b4286490d7ac5494f4ad10c4cf4c5d4f50d21641r? @fee1-dead