Instantiate instead of erasing binder when probing param methods#108843
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 10, 2023
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 9, 2023
…rs-method-probe, r=jackh726 Instantiate instead of erasing binder when probing param methods Fixes rust-lang#108836 There is a really old comment saying that a `WhereClauseCandidate` probe candidate "should not contain any inference variables", but I'm not really confident that that comment applies anymore. In contrast, other candidates that we assemble during method probe contain inference variables in their substitutions (e.g. `InherentImplCandidate`)... Since this change is made only to support a nightly feature, I'm happy to gate the new behavior behind this feature flag or discuss it further. r? types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#108843 (Instantiate instead of erasing binder when probing param methods) - rust-lang#109985 (Add little `is_test_crate` function) - rust-lang#110028 (Migrate `rustc_hir_analysis` to session diagnostic [Part 3]) - rust-lang#110095 (Migrate remainder of rustc_ty_utils to `SessionDiagnostic`) - rust-lang#110108 (Add renaming of ignore-git to changelog) - rust-lang#110114 (compiletest: Give a better error message if `node` isn't installed) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108836
There is a really old comment saying that a
WhereClauseCandidateprobe candidate "should not contain any inference variables", but I'm not really confident that that comment applies anymore. In contrast, other candidates that we assemble during method probe contain inference variables in their substitutions (e.g.InherentImplCandidate)...Since this change is made only to support a nightly feature, I'm happy to gate the new behavior behind this feature flag or discuss it further.
r? types