Migrate remainder of rustc_ty_utils to SessionDiagnostic#110095
Merged
bors merged 4 commits intorust-lang:masterfrom Apr 10, 2023
Merged
Migrate remainder of rustc_ty_utils to SessionDiagnostic#110095bors merged 4 commits intorust-lang:masterfrom
SessionDiagnostic#110095bors merged 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Apr 8, 2023
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Looks fine to me, other than one question about a fatal error that was turned into a delayed bug.
Fix formatting that rustfmt can't handle currently. Co-authored-by: Michael Goulet <michael@errs.io>
Contributor
|
r=me after adding that UI test I shared above. |
Contributor
|
thanks r? @compiler-errors @bors r+ |
Collaborator
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 9, 2023
…, r=compiler-errors Migrate remainder of rustc_ty_utils to `SessionDiagnostic` This moves the remaining errors in `rust_ty_utils` to `SessionsDiagnostic`. r? `@davidtwco`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#108843 (Instantiate instead of erasing binder when probing param methods) - rust-lang#109985 (Add little `is_test_crate` function) - rust-lang#110028 (Migrate `rustc_hir_analysis` to session diagnostic [Part 3]) - rust-lang#110095 (Migrate remainder of rustc_ty_utils to `SessionDiagnostic`) - rust-lang#110108 (Add renaming of ignore-git to changelog) - rust-lang#110114 (compiletest: Give a better error message if `node` isn't installed) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the remaining errors in
rust_ty_utilstoSessionsDiagnostic.r? @davidtwco