Skip to content

Replace yes command by while-echo in test tests/ui/process/process-sigpipe.rs#109379

Merged
bors merged 1 commit intorust-lang:masterfrom
flba-eb:108596_fixtest_sigpipe
Apr 26, 2023
Merged

Replace yes command by while-echo in test tests/ui/process/process-sigpipe.rs#109379
bors merged 1 commit intorust-lang:masterfrom
flba-eb:108596_fixtest_sigpipe

Conversation

@flba-eb
Copy link
Contributor

@flba-eb flba-eb commented Mar 20, 2023 •
edited
Loading

The yes command is not available on all platforms.

Fixes #108596.

Inviting @mvf as he contributed to this patch. Thanks! This issue has been discussed in #106673 but was moved to #108596 to get going.

CC @gh-tr

r? @workingjubilee
@rustbot label +O-neutrino

Notes about the comments #106673 (comment):

  • The echo command is /proc/boot/echo (not built-in)
  • /bin/sh is a symlink to /proc/boot/ksh
# ls -l /bin/sh /proc/boot/ksh /proc/boot/echo
lrwxrwxrwx   1 root      root             14 Mar 20 07:52 /bin/sh -> /proc/boot/ksh
-r-xr-xr-x   1 root      root           9390 Sep 12  2022 /proc/boot/echo
-r-xr-xr-x   1 root      root         308114 Sep 12  2022 /proc/boot/ksh

@flba-eb
Replace yes command by while-echo
3970793 
The `yes` command is not available on all platforms.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-neutrino OS: QNX Neutrino, a POSIX-compatible real-time operating system labels Mar 20, 2023
@flba-eb flba-eb marked this pull request as ready for review March 20, 2023 09:29
@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 26, 2023

📌 Commit 3970793 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@jyn514 jyn514 mentioned this pull request Apr 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
@bors
Auto merge of rust-lang#110839 - jyn514:rollup-uikilwm, r=jyn514
ae3ab14 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#108416 (black_box doc corrections for clarification - Issue rust-lang#107957)
 - rust-lang#109379 (Replace `yes` command by `while-echo` in test `tests/ui/process/process-sigpipe.rs`)
 - rust-lang#110266 (Update documentation wording on path 'try_exists' functions)
 - rust-lang#110329 (Improve tests for rust-lang#110138)
 - rust-lang#110418 (Spelling rustdoc)
 - rust-lang#110587 (Fix `std` compilation error for wasi+atomics)
 - rust-lang#110594 (`rustc --help` add `--cfg` SPEC declaration.)
 - rust-lang#110792 (Use the standard macOS CI runner)
 - rust-lang#110817 (Add regression tests for const-generic inherent associated types)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fff8503 into rust-lang:master Apr 26, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 26, 2023
@flba-eb flba-eb deleted the 108596_fixtest_sigpipe branch February 24, 2024 12:13
@xingxue-ibm xingxue-ibm mentioned this pull request Feb 12, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 19, 2025
@matthiaskrgr
Rollup merge of rust-lang#136936 - xingxue-ibm:sigpipe-test, r=workin…
616b6c3 
…gjubilee

Use 'yes' instead of 'while-echo' in tests/ui/process/process-sigpipe.rs except 'nto'

The `sh` of AIX prints a message about a broken pipe when using the `while-echo` command. It works as expected when using the `yes` command instead. `yes` was originally used in this test but was later replaced with `while-echo` because QNX Neutrino does not have `yes` ([Replace yes command by while-echo in test tests/ui/process/process-sigpipe.rs](rust-lang#109379)). This PR updates the test to use `while-echo` for QNX Neutrino while reverting to `yes` for other platforms.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
@rust-timer
Unrolled build for rust-lang#136936
edcde4c 
Rollup merge of rust-lang#136936 - xingxue-ibm:sigpipe-test, r=workingjubilee

Use 'yes' instead of 'while-echo' in tests/ui/process/process-sigpipe.rs except 'nto'

The `sh` of AIX prints a message about a broken pipe when using the `while-echo` command. It works as expected when using the `yes` command instead. `yes` was originally used in this test but was later replaced with `while-echo` because QNX Neutrino does not have `yes` ([Replace yes command by while-echo in test tests/ui/process/process-sigpipe.rs](rust-lang#109379)). This PR updates the test to use `while-echo` for QNX Neutrino while reverting to `yes` for other platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@workingjubilee workingjubilee

Labels

O-neutrino OS: QNX Neutrino, a POSIX-compatible real-time operating system S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for test case disabled in QNX Neutrino tests/ui/process/process-sigpipe.rs

5 participants

@flba-eb @jyn514 @bors @workingjubilee @rustbot