Add `never_patterns` feature gate#118157

Nadrieril · 2023-11-22T01:08:31Z

This PR adds the feature gate and most basic parsing for the experimental never_patterns feature. See the tracking issue (#118155) for details on the experiment.

@scottmcm has agreed to be my lang-team liaison for this experiment.

rustbot · 2023-11-22T01:08:39Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-11-22T01:08:41Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

rustbot · 2023-11-22T02:14:50Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Nadrieril · 2023-11-22T05:19:07Z

@rustbot ready

traviscross · 2023-11-22T09:30:51Z

@rustbot labels +I-lang-nominated

Let's discuss this in triage to ensure the experiment can move forward.

scottmcm · 2023-11-22T16:14:09Z

We discussed this in the lang triage meeting today.

Meeting consensus with quorum was that this experiment can go forward (without needing an FCP or similar to start the experiment)!

Un-tagging lang; this can land once reviewed.

Nadrieril · 2023-11-29T01:05:50Z

r? @compiler-errors

tests/ui/pattern/never_patterns.rs

tests/ui/feature-gates/feature-gate-never_patterns.rs

src/tools/rustfmt/src/patterns.rs

src/librustdoc/clean/utils.rs

compiler/rustc_parse/src/parser/pat.rs

compiler/rustc_mir_build/src/thir/pattern/deconstruct_pat.rs

compiler/rustc_mir_build/src/build/matches/simplify.rs

compiler/rustc_hir_typeck/src/pat.rs

Nadrieril · 2023-11-29T02:30:17Z

@rustbot ready

compiler-errors

one nit

please squash all commits into one so that rustfmt isn't unnecessarily touched in the git history at all, and then r=me

src/tools/rustfmt/src/patterns.rs

Nadrieril · 2023-11-29T03:01:13Z

@bors r=compiler-errors

bors · 2023-11-29T03:01:15Z

📌 Commit a3838c8 has been approved by compiler-errors

It is now in the queue for this repository.

…r=compiler-errors Add `never_patterns` feature gate This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment. `@scottmcm` has agreed to be my lang-team liaison for this experiment.

…r=compiler-errors Add `never_patterns` feature gate This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment. ``@scottmcm`` has agreed to be my lang-team liaison for this experiment.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118157 (Add `never_patterns` feature gate) - rust-lang#118191 (Suggest `let` or `==` on typo'd let-chain) - rust-lang#118231 (also add is_empty to const raw slices) - rust-lang#118333 (Print list of missing target features when calling a function with target features outside an unsafe block) - rust-lang#118426 (ConstProp: Correctly remove const if unknown value assigned to it.) - rust-lang#118428 (rustdoc: Move `AssocItemRender` and `RenderMode` to `html::render`.) - rust-lang#118438 (Update nto-qnx.md) Failed merges: - rust-lang#118268 (Pretty print `Fn<(..., ...)>` trait refs with parentheses (almost) always) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, r=compiler-errors Add `never_patterns` feature gate This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment. `@scottmcm` has agreed to be my lang-team liaison for this experiment.

…r=compiler-errors Add `never_patterns` feature gate This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment. `@scottmcm` has agreed to be my lang-team liaison for this experiment.

Nadrieril added the F-never_patterns `#![feature(never_patterns)]` label Nov 22, 2023

rustbot assigned davidtwco Nov 22, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 22, 2023

Nadrieril force-pushed the never_pat-feature-gate branch from 472b9c7 to beef0af Compare November 22, 2023 01:13

This comment was marked as off-topic.

Sign in to view