Print list of missing target features when calling a function with target features outside an unsafe block#118333
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 29, 2023
eduardosm:print-missing-target-features
Merged
Print list of missing target features when calling a function with target features outside an unsafe block#118333bors merged 2 commits intorust-lang:masterfrom eduardosm:print-missing-target-features
bors merged 2 commits intorust-lang:masterfrom
eduardosm:print-missing-target-features
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
ghost
reviewed
Nov 26, 2023
| CallToFunctionWith, | ||
| CallToFunctionWith { | ||
| /// Target features enabled in callee's `#[target_feature]` but missing in | ||
| /// caller's `#[target_feature]` |
There was a problem hiding this comment.
Suggested change
| /// caller's `#[target_feature]` | |
| /// caller's `#[target_feature]`. |
est31
approved these changes
Nov 27, 2023
Member
est31
left a comment
est31
left a comment
There was a problem hiding this comment.
Thanks for filing!
LGTM except one question: could you add something to the existing test that excercises the mir_transform_target_feature_call_note case with multiple target features? Because right now, there is only tests for one.
…rget features outside an unsafe block
Contributor
Author
|
Done. I just learned about |
Member
Yeah good point, we'd want that change be present there, too. So the .thir.stderr file should have the same changes in the end as .mir.stderr, ideally. |
…unction with target features outside an unsafe block
Contributor
Author
|
Done, also added a test to cover the case of an unsafe function with a |
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 29, 2023
…tures, r=est31 Print list of missing target features when calling a function with target features outside an unsafe block Fixes rust-lang#108680 Supersedes rust-lang#109710. I used the same wording for the messages, but the implementation is different. r? `@est31`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 29, 2023
…tures, r=est31 Print list of missing target features when calling a function with target features outside an unsafe block Fixes rust-lang#108680 Supersedes rust-lang#109710. I used the same wording for the messages, but the implementation is different. r? ``@est31``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118157 (Add `never_patterns` feature gate) - rust-lang#118191 (Suggest `let` or `==` on typo'd let-chain) - rust-lang#118231 (also add is_empty to const raw slices) - rust-lang#118333 (Print list of missing target features when calling a function with target features outside an unsafe block) - rust-lang#118426 (ConstProp: Correctly remove const if unknown value assigned to it.) - rust-lang#118428 (rustdoc: Move `AssocItemRender` and `RenderMode` to `html::render`.) - rust-lang#118438 (Update nto-qnx.md) Failed merges: - rust-lang#118268 (Pretty print `Fn<(..., ...)>` trait refs with parentheses (almost) always) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2023
Rollup merge of rust-lang#118333 - eduardosm:print-missing-target-features, r=est31 Print list of missing target features when calling a function with target features outside an unsafe block Fixes rust-lang#108680 Supersedes rust-lang#109710. I used the same wording for the messages, but the implementation is different. r? `@est31`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108680
Supersedes #109710. I used the same wording for the messages, but the implementation is different.
r? @est31