Skip to content

Add const Rem#143040

Merged
bors merged 1 commit intorust-lang:masterfrom
scimind2460:patch-1
Jul 5, 2025
Merged

Add const Rem#143040
bors merged 1 commit intorust-lang:masterfrom
scimind2460:patch-1

Conversation

@scimind2460
Copy link
Contributor

@scimind2460 scimind2460 commented Jun 26, 2025 •
edited by rustbot
Loading

I forgot to make Rem const for floats in #143000. This is a quick-fix PR for that error.

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 26, 2025
@workingjubilee
Copy link
Member

workingjubilee commented Jun 27, 2025

will r+ if you correct the commit message to describe what it does

@workingjubilee workingjubilee changed the title Quick fix for #143000 Add const Rem Jun 27, 2025
@scimind2460
Copy link
Contributor Author

scimind2460 commented Jun 27, 2025

Unfortunately, since my commit is a GitHub-verified commit, I'll have to redo the entire thing as I can't just git commit --amend

@workingjubilee
Copy link
Member

workingjubilee commented Jun 27, 2025

@scimind2460 I seriously do not care if your commits are "verified" or not.

@fmease
Copy link
Member

fmease commented Jul 1, 2025

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@fee1-dead fee1-dead mentioned this pull request Jul 3, 2025
Merged
@RalfJung
Copy link
Member

RalfJung commented Jul 3, 2025 •
edited
Loading

@scimind2460 Surely you can just amend and re-sign?
But yeah signing commits doesn't really do much in our workflow. We are centralized on GH and trust that GH ensures that the contents of your repo are yours.

@workingjubilee
Copy link
Member

workingjubilee commented Jul 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 4, 2025

📌 Commit 2d1aa58 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025
@workingjubilee workingjubilee mentioned this pull request Jul 5, 2025
Merged
bors added a commit that referenced this pull request Jul 5, 2025
@bors
Auto merge of #143473 - workingjubilee:rollup-bxie7zg, r=scottmcm
fd9ca71 
Rollup of 11 pull requests

Successful merges:

 - #142440 (`tests/ui`: A New Order [14/N])
 - #143040 (Add `const Rem`)
 - #143086 (Update poison.rs to fix the typo (sys->sync))
 - #143202 (`tests/ui`: A New Order [18/N])
 - #143296 (`tests/ui`: A New Order [21/N])
 - #143297 (`tests/ui`: A New Order [22/N])
 - #143299 (`tests/ui`: A New Order [24/N])
 - #143300 (`tests/ui`: A New Order [25/N])
 - #143397 (test passing a `VaList` from rust to C)
 - #143410 (Block SIMD in transmute_immediate; delete `OperandValueKind`)
 - #143452 (Fix CLI completion check in `tidy`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3b52238 into rust-lang:master Jul 5, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 5, 2025
rust-timer added a commit that referenced this pull request Jul 5, 2025
@rust-timer
Unrolled build for #143040
6183aad 
Rollup merge of #143040 - SciMind2460:patch-1, r=workingjubilee

Add `const Rem`
@scimind2460
Copy link
Contributor Author

scimind2460 commented Jul 10, 2025

I apologise for the problems this may have caused, @workingjubilee and @RalfJung!
What I meant is that my commits were on GitHub and I couldn't change their names, and my local copy was really badly messed up for some reason.
I will take a break and restart my GitHub work soon.

@scimind2460 scimind2460 deleted the patch-1 branch July 10, 2025 05:18
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
@workingjubilee
Rollup merge of rust-lang#143040 - SciMind2460:patch-1, r=workingjubilee
7ebe19d 
Add `const Rem`
@RalfJung RalfJung mentioned this pull request Jul 11, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@workingjubilee workingjubilee

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

6 participants

@scimind2460 @rustbot @workingjubilee @fmease @RalfJung @bors