Fix CLI completion check in tidy

[Kobzol]

The list of CLI completion files that were generated and that were checked by x test tidy was not synced. Recently, some PR only updated some of the files, which caused the rest of the files (not checked by x test tidy) to be dirty on master. This PR fixes the logic in bootstrap to always synchronize the list of completion paths.

Fixes: #143451

r? @jieyouxu

[rustbot]

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

[Kobzol]

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] build_helper test:false 0.669
error: function call inside of `expect`
   --> src/bootstrap/src/core/build_steps/run.rs:315:22
    |
315 |                     .expect(&format!("writing {} completion", path.display()));
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("writing {} completion", path.display()))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
    = note: `-D clippy::expect-fun-call` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::expect_fun_call)]`

Funny, clippy didn't detect this when it was inside a macro.

[jieyouxu]

Funny, clippy didn't detect this when it was inside a macro.

Aren't many lints intentionally not fired against code whose span comes from macro expansions? Anyway

[jieyouxu]

Thanks

[jieyouxu]

@bors r+ rollup

[bors]

📌 Commit 1a1f561 has been approved by jieyouxu

It is now in the queue for this repository.

[klensy]

Sorry, i've updated only ones that caused build or tidy fails.