Skip to content

tests/ui/issues/: The Issues Strike Back [2/N]#144397

Merged
bors merged 2 commits intorust-lang:masterfrom
Kivooeo:issue2
Aug 1, 2025
Merged

tests/ui/issues/: The Issues Strike Back [2/N]#144397
bors merged 2 commits intorust-lang:masterfrom
Kivooeo:issue2

Conversation

@Kivooeo
Copy link
Member

@Kivooeo Kivooeo commented Jul 24, 2025

Some tests/ui/issues/ housekeeping, to trim down number of tests directly under tests/ui/issues/. Part of #133895.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

jieyouxu
jieyouxu requested changes Jul 31, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some feedback.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025
@Kivooeo
Copy link
Member Author

Kivooeo commented Jul 31, 2025

Fixed, most of them already had numbers, I just forget to mention that in exactly this part I pushed change with adding numbers to a second commit (in others I rebased and added them to a first commit)

jieyouxu
jieyouxu approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Aug 1, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit a4a5bf5 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2025
RalfJung added a commit to RalfJung/rust that referenced this pull request Aug 1, 2025
@RalfJung
Rollup merge of rust-lang#144397 - Kivooeo:issue2, r=jieyouxu
369d7a3 
`tests/ui/issues/`: The Issues Strike Back [2/N]

Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895.

r? `@jieyouxu`
@RalfJung RalfJung mentioned this pull request Aug 1, 2025
Merged
bors added a commit that referenced this pull request Aug 1, 2025
@bors
Auto merge of #144773 - RalfJung:rollup-uif2yyj, r=RalfJung
924a5a4 
Rollup of 6 pull requests

Successful merges:

 - #144397 (`tests/ui/issues/`: The Issues Strike Back [2/N])
 - #144410 (Make tier 3 musl targets link dynamically by default)
 - #144708 (Add tracing to step.rs and friends)
 - #144730 (Create a typed wrapper for codegen backends in bootstrap)
 - #144771 (Remove some noisy triagebot pings for myself)
 - #144772 (add unsupported_calling_conventions to lint list)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37ad077 into rust-lang:master Aug 1, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Aug 1, 2025
rust-timer added a commit that referenced this pull request Aug 1, 2025
@rust-timer
Unrolled build for #144397
a85bbc2 
Rollup merge of #144397 - Kivooeo:issue2, r=jieyouxu

`tests/ui/issues/`: The Issues Strike Back [2/N]

Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of #133895.

r? ``@jieyouxu``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Kivooeo @rustbot @jieyouxu @bors