Skip to content

add unsupported_calling_conventions to lint list#144772

Merged
bors merged 1 commit intorust-lang:masterfrom
RalfJung:unsupported_calling_conventions
Aug 1, 2025
Merged

add unsupported_calling_conventions to lint list#144772
bors merged 1 commit intorust-lang:masterfrom
RalfJung:unsupported_calling_conventions

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 1, 2025

Seems like you can emit lints without them being on the list, but users cannot control them then... oops.

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 1, 2025
@RalfJung RalfJung mentioned this pull request Aug 1, 2025
Open
@RalfJung RalfJung added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 1, 2025
@lqd
Copy link
Member

lqd commented Aug 1, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit 0cc4be2 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025
@lcnr lcnr assigned lqd and unassigned lcnr Aug 1, 2025
@RalfJung
Copy link
Member Author

RalfJung commented Aug 1, 2025 •
edited
Loading

@bors rollup

There's a beta branching today, would be nice to get this included. But if not we can backport it.

It's probably too late for the upcoming stable release? @rust-lang/infra
(The PR that introduced the issue is #141435 so it's going to become stable in a week.)

@RalfJung RalfJung mentioned this pull request Aug 1, 2025
Merged
@lqd
Copy link
Member

lqd commented Aug 1, 2025

(Could be good to have this exercised in a test in a future PR, not this one since it's somewhat urgent)

@jieyouxu
Copy link
Member

jieyouxu commented Aug 1, 2025

(Backports are handled by @rust-lang/release not infra)

@Noratrieb
Copy link
Member

Noratrieb commented Aug 1, 2025

@rust-lang/release this should be included in 1.89

@RalfJung
Copy link
Member Author

RalfJung commented Aug 1, 2025

(Could be good to have this exercised in a test in a future PR, not this one since it's somewhat urgent)

I mean then we should have tests like this for all lints...
really ideally we'd have some systematic check for this, e.g. in tidy.

@jieyouxu
Copy link
Member

jieyouxu commented Aug 1, 2025

Beta-backport accepted as discussed in #t-compiler/backports > #144772: beta-nominated.

@rustbot label: +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 1, 2025
bors added a commit that referenced this pull request Aug 1, 2025
@bors
Auto merge of #144773 - RalfJung:rollup-uif2yyj, r=RalfJung
924a5a4 
Rollup of 6 pull requests

Successful merges:

 - #144397 (`tests/ui/issues/`: The Issues Strike Back [2/N])
 - #144410 (Make tier 3 musl targets link dynamically by default)
 - #144708 (Add tracing to step.rs and friends)
 - #144730 (Create a typed wrapper for codegen backends in bootstrap)
 - #144771 (Remove some noisy triagebot pings for myself)
 - #144772 (add unsupported_calling_conventions to lint list)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 21140a5 into rust-lang:master Aug 1, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 1, 2025
@rust-timer
Unrolled build for #144772
04efc4b 
Rollup merge of #144772 - RalfJung:unsupported_calling_conventions, r=lqd

add unsupported_calling_conventions to lint list

Seems like you can emit lints without them being on the list, but users cannot control them then... *oops*.
@rustbot rustbot added this to the 1.90.0 milestone Aug 1, 2025
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 1, 2025
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.90.0, 1.89.0 Aug 1, 2025
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 1, 2025
Merged
bors added a commit that referenced this pull request Aug 2, 2025
@bors
Auto merge of #144800 - Mark-Simulacrum:beta-next, r=Mark-Simulacrum
4a18378 
[beta] backports

Backport:

*  add unsupported_calling_conventions to lint list #144772
*  thread name in stack overflow message #144500
*  rustdoc: don't treat methods under const impls or traits as const #143381
* [beta] Clippy beta backport #144742

r? `@Mark-Simulacrum`
@RalfJung RalfJung deleted the unsupported_calling_conventions branch August 6, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

8 participants

@RalfJung @rustbot @lqd @bors @jieyouxu @Noratrieb @Mark-Simulacrum @lcnr