std: merge definitions of `StdioPipes`#146639

joboet · 2025-09-16T13:50:28Z

All platforms define this structure the same way, so we can just put it in the process module directly.

rustbot · 2025-09-16T13:50:32Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Mark-Simulacrum · 2025-09-21T17:27:06Z

r=me with rebase

All platforms define this structure the same way, so we can just put it in the `process` module directly.

rustbot · 2025-09-21T17:45:59Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Mark-Simulacrum · 2025-09-21T17:49:47Z

@bors r+

bors · 2025-09-21T17:49:50Z

📌 Commit 87a00f6 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.

Rollup of 4 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #146486 (Improve `core::sync::atomic` coverage) - #146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - #146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146639 - joboet:shared-stdiopipes, r=Mark-Simulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.

…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure) - rust-lang#146486 (Improve `core::sync::atomic` coverage) - rust-lang#146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - rust-lang#146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup

…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.

…ulacrum std: reorganize pipe implementations Currently, there are two distinct types called `AnonPipe` in `std`: * The one used to implement `io::pipe` (in `sys::anonymous_pipe`) * The one used to implement `Stdin`/`Stdout`/`Stderr` (in `sys::pal::pipe`) On Windows, these actually have different semantics, as one of the handles returned by the `sys::pal::pipe` version is opened for asynchronous operation in order to support `read2`, whereas the `sys::anonymous_pipe` version does not do so. Thus the naming is extremely confusing. To fix this, this PR renames the `sys::anonymous_pipe` version of `AnonPipe` to simply `Pipe`, whereas the `sys::pal::pipe` version is now called `ChildPipe`. Additionally, * `sys::anonymous_pipe` is now also just called `sys::pipe`. * On Windows, `sys::pal::pipe` has been moved to `sys::process` and is now called `sys::process::child_pipe`. * On non-Windows platforms, pipe creation is now exclusively handled by `sys::pipe` and `ChildPipe` is defined as a type alias to `Pipe` within `sys::process`. And lastly, the `read2` function (originally in `sys::pal::pipe`) is now called `read_output` and defined by `sys::process`, as (at least on Windows) it is only usable with `ChildPipe`. Includes rust-lang#146639 for convenience.

Rollup merge of #146794 - joboet:reorganize-pipe, r=Mark-Simulacrum std: reorganize pipe implementations Currently, there are two distinct types called `AnonPipe` in `std`: * The one used to implement `io::pipe` (in `sys::anonymous_pipe`) * The one used to implement `Stdin`/`Stdout`/`Stderr` (in `sys::pal::pipe`) On Windows, these actually have different semantics, as one of the handles returned by the `sys::pal::pipe` version is opened for asynchronous operation in order to support `read2`, whereas the `sys::anonymous_pipe` version does not do so. Thus the naming is extremely confusing. To fix this, this PR renames the `sys::anonymous_pipe` version of `AnonPipe` to simply `Pipe`, whereas the `sys::pal::pipe` version is now called `ChildPipe`. Additionally, * `sys::anonymous_pipe` is now also just called `sys::pipe`. * On Windows, `sys::pal::pipe` has been moved to `sys::process` and is now called `sys::process::child_pipe`. * On non-Windows platforms, pipe creation is now exclusively handled by `sys::pipe` and `ChildPipe` is defined as a type alias to `Pipe` within `sys::process`. And lastly, the `read2` function (originally in `sys::pal::pipe`) is now called `read_output` and defined by `sys::process`, as (at least on Windows) it is only usable with `ChildPipe`. Includes #146639 for convenience.

std: reorganize pipe implementations Currently, there are two distinct types called `AnonPipe` in `std`: * The one used to implement `io::pipe` (in `sys::anonymous_pipe`) * The one used to implement `Stdin`/`Stdout`/`Stderr` (in `sys::pal::pipe`) On Windows, these actually have different semantics, as one of the handles returned by the `sys::pal::pipe` version is opened for asynchronous operation in order to support `read2`, whereas the `sys::anonymous_pipe` version does not do so. Thus the naming is extremely confusing. To fix this, this PR renames the `sys::anonymous_pipe` version of `AnonPipe` to simply `Pipe`, whereas the `sys::pal::pipe` version is now called `ChildPipe`. Additionally, * `sys::anonymous_pipe` is now also just called `sys::pipe`. * On Windows, `sys::pal::pipe` has been moved to `sys::process` and is now called `sys::process::child_pipe`. * On non-Windows platforms, pipe creation is now exclusively handled by `sys::pipe` and `ChildPipe` is defined as a type alias to `Pipe` within `sys::process`. And lastly, the `read2` function (originally in `sys::pal::pipe`) is now called `read_output` and defined by `sys::process`, as (at least on Windows) it is only usable with `ChildPipe`. Includes rust-lang/rust#146639 for convenience.

rustbot assigned Mark-Simulacrum Sep 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 16, 2025

joboet mentioned this pull request Sep 19, 2025

std: reorganize pipe implementations #146794

Merged

hkBst approved these changes Sep 21, 2025

View reviewed changes

std: merge definitions of StdioPipes

87a00f6

All platforms define this structure the same way, so we can just put it in the `process` module directly.

joboet force-pushed the shared-stdiopipes branch from 189007f to 87a00f6 Compare September 21, 2025 17:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2025

This was referenced Sep 21, 2025

Rollup of 5 pull requests #146860

Closed

Rollup of 4 pull requests #146862

Merged

bors merged commit adfc111 into rust-lang:master Sep 21, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Sep 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

std: merge definitions of `StdioPipes`#146639