Merged
Conversation
Co-authored-by: Anne Stijns <anstijns@gmail.com>
Co-authored-by: Anne Stijns <anstijns@gmail.com>
All platforms define this structure the same way, so we can just put it in the `process` module directly.
…zelmann Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? ``@oli-obk`` cc ``@JonathanBrouwer`` ``@jdonszelmann``
…erage, r=ibraheemdev Improve `core::sync::atomic` coverage This PR improves the `core::sync::atomic` coverage by adding new tests to `coretests`. r? libs
…ulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See rust-lang#146601 (comment) r? ``@Mark-Simulacrum``
…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 7e4b8d702f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7e4b8d7 (parent) -> 9f32ccf (this PR) Test differencesShow 691 test diffsStage 0
Stage 1
Stage 2
(and 255 additional test diffs) Additionally, 336 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 9f32ccf35fb877270bc44a86a126440f04d676d0 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Sep 22, 2025
Collaborator
|
Finished benchmarking commit (9f32ccf): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%, secondary 3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 471.863s -> 471.273s (-0.13%) |
This was referenced Sep 22, 2025
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure) - rust-lang#146486 (Improve `core::sync::atomic` coverage) - rust-lang#146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - rust-lang#146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::sync::atomiccoverage #146486 (Improvecore::sync::atomiccoverage)--test-argsregression test #146606 (ci: x86_64-gnu-tools: Add--test-argsregression test)StdioPipes#146639 (std: merge definitions ofStdioPipes)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup