bootstrap: add `Builder::rustc_cmd` that includes the lib path#147419

cuviper · 2025-10-06T21:50:05Z

When building with rust.rpath = false, every rustc invocation needs
to include the library path as well. I particularly ran into this in
generate_target_spec_json_schema when testing 1.91-beta in Fedora,
where we do disable rpath for our system builds. The new helper function
will hopefully encourage the right thing going forward.

rustbot · 2025-10-06T21:50:11Z

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

cuviper · 2025-10-06T21:50:32Z

I particularly ran into this [...] when testing 1.91-beta in Fedora,

@rustbot label beta-nominated

Zalathar · 2025-10-07T04:22:28Z

r? bootstrap

jieyouxu · 2025-10-07T06:10:06Z

The idea makes sense to me. Want to hear a second opinion on the API and its naming.

src/bootstrap/src/core/builder/mod.rs

When building with `rust.rpath = false`, every `rustc` invocation needs to include the library path as well. I particularly ran into this in `generate_target_spec_json_schema` when testing 1.91-beta in Fedora, where we do disable rpath for our system builds. The new helper function will hopefully encourage the right thing going forward.

jieyouxu

I don't have an alternative shape in mind, and this seems very reasonable (esp. with the added comment). Thanks.

View changes since this review

jieyouxu · 2025-10-09T05:24:06Z

r? jieyouxu @bors r=Zalathar,jieyouxu rollup

bors · 2025-10-09T05:24:08Z

📌 Commit 03cdcb5 has been approved by Zalathar,jieyouxu

It is now in the queue for this repository.

…lathar,jieyouxu bootstrap: add `Builder::rustc_cmd` that includes the lib path When building with `rust.rpath = false`, every `rustc` invocation needs to include the library path as well. I particularly ran into this in `generate_target_spec_json_schema` when testing 1.91-beta in Fedora, where we do disable rpath for our system builds. The new helper function will hopefully encourage the right thing going forward.

Rollup of 7 pull requests Successful merges: - #146568 (Port the implemention of SIMD intrinsics from Miri to const-eval) - #147373 (give a better example why `std` modules named like primitives are needed) - #147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path) - #147457 (specialize slice::fill to use memset when possible) - #147468 (Implement fs api set_times and set_times_nofollow) - #147489 (Prefer to use repeat_n over repeat().take()) - #147506 (compiletest: Isolate public APIs and minimize public surface area) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - #146568 (Port the implemention of SIMD intrinsics from Miri to const-eval) - #147373 (give a better example why `std` modules named like primitives are needed) - #147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path) - #147420 (Add diagnostic items for `pub mod consts` of FP types) - #147457 (specialize slice::fill to use memset when possible) - #147467 (Fix double warnings on `#[no_mangle]`) - #147470 (Clarify how to remediate the panic_immediate_abort error) - #147480 (Do not invalidate CFG caches in CtfeLimit.) - #147481 (format: some small cleanup) - #147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`) - #147489 (Prefer to use repeat_n over repeat().take()) - #147506 (compiletest: Isolate public APIs and minimize public surface area) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147419 - cuviper:bootstrap-rustc-libs, r=Zalathar,jieyouxu bootstrap: add `Builder::rustc_cmd` that includes the lib path When building with `rust.rpath = false`, every `rustc` invocation needs to include the library path as well. I particularly ran into this in `generate_target_spec_json_schema` when testing 1.91-beta in Fedora, where we do disable rpath for our system builds. The new helper function will hopefully encourage the right thing going forward.

jieyouxu · 2025-10-09T11:53:28Z

Voting in #t-infra/bootstrap/backports > #147419: beta-nominated, marking as accepted.

@rustbot label: +beta-accepted

stefson · 2025-10-11T16:30:40Z

@cuviper

do you think this PR might fix my issue with my custom target? see #146930

cuviper · 2025-10-11T16:58:20Z

@stefson, yes, I think it probably will! I'm working on backports in #147571.

[beta] backports - Don't normalize higher-ranked assumptions if they're not used #147299 - Fix target list of `link_section` #147418 - bootstrap: add `Builder::rustc_cmd` that includes the lib path #147419 - Update LLVM to 21.1.2 #146953 - Remove the temporary directory when a check ends -- part of #147518 r? cuviper

Rollup of 12 pull requests Successful merges: - rust-lang/rust#146568 (Port the implemention of SIMD intrinsics from Miri to const-eval) - rust-lang/rust#147373 (give a better example why `std` modules named like primitives are needed) - rust-lang/rust#147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path) - rust-lang/rust#147420 (Add diagnostic items for `pub mod consts` of FP types) - rust-lang/rust#147457 (specialize slice::fill to use memset when possible) - rust-lang/rust#147467 (Fix double warnings on `#[no_mangle]`) - rust-lang/rust#147470 (Clarify how to remediate the panic_immediate_abort error) - rust-lang/rust#147480 (Do not invalidate CFG caches in CtfeLimit.) - rust-lang/rust#147481 (format: some small cleanup) - rust-lang/rust#147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`) - rust-lang/rust#147489 (Prefer to use repeat_n over repeat().take()) - rust-lang/rust#147506 (compiletest: Isolate public APIs and minimize public surface area) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Zalathar Oct 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 6, 2025

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 6, 2025

rustbot assigned Mark-Simulacrum and unassigned Zalathar Oct 7, 2025

Zalathar reviewed Oct 7, 2025

View reviewed changes

src/bootstrap/src/core/builder/mod.rs Outdated Show resolved Hide resolved

cuviper force-pushed the bootstrap-rustc-libs branch from babf9a2 to 03cdcb5 Compare October 7, 2025 16:56

jieyouxu approved these changes Oct 9, 2025

View reviewed changes

rustbot assigned jieyouxu and unassigned Mark-Simulacrum Oct 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025

Zalathar mentioned this pull request Oct 9, 2025

Rollup of 7 pull requests #147510

Closed

Zalathar mentioned this pull request Oct 9, 2025

Rollup of 12 pull requests #147512

Merged

bors merged commit 68f9b3b into rust-lang:master Oct 9, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 9, 2025

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 9, 2025

cuviper mentioned this pull request Oct 10, 2025

[beta] backports #147571

Merged

cuviper modified the milestones: 1.92.0, 1.91.0 Oct 11, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2025

github-actions bot mentioned this pull request Oct 15, 2025

Toolchain upgrade to nightly-2025-10-10 flux-rs/flux#1332

Closed

cuviper deleted the bootstrap-rustc-libs branch December 17, 2025 00:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bootstrap: add `Builder::rustc_cmd` that includes the lib path#147419