Skip to content

Prefer to use repeat_n over repeat().take()#147489

Merged
bors merged 3 commits intorust-lang:masterfrom
chenyukang:yukang-prefer-repeat-n
Oct 9, 2025
Merged

Prefer to use repeat_n over repeat().take()#147489
bors merged 3 commits intorust-lang:masterfrom
chenyukang:yukang-prefer-repeat-n

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 8, 2025

More from #147464, but batch processed with ast-grep to find and replace.

second commit add notes for library: affaf53

r? @RalfJung

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 8, 2025
@RalfJung
Copy link
Member

RalfJung commented Oct 8, 2025 •
edited
Loading

r? compiler
Sorry, I don't have time to review this. There's a reason I am not in the review rotation, and this PR is not specific to any of the areas I am an expert in. No reason to assign it to me.

@rustbot rustbot assigned petrochenkov and unassigned RalfJung Oct 8, 2025
Kivooeo
Kivooeo approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for future reviewer)
I checked all files, that's totally fine, can't approve since have no rights yet

View changes since this review

@oli-obk
Copy link
Contributor

oli-obk commented Oct 9, 2025

@bors r=Kivooeo,oli-obk

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

📌 Commit 53c79f4 has been approved by Kivooeo,oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 9, 2025
@Zalathar
Rollup merge of rust-lang#147489 - chenyukang:yukang-prefer-repeat-n,…
1201c90 
… r=Kivooeo,oli-obk

Prefer to use repeat_n over repeat().take()

More from rust-lang#147464, but batch processed with `ast-grep` to find and replace.

second commit add notes for library: rust-lang@affaf53

r? `@RalfJung`
@Zalathar Zalathar mentioned this pull request Oct 9, 2025
Closed
bors added a commit that referenced this pull request Oct 9, 2025
@bors
Auto merge of #147510 - Zalathar:rollup-zlcd471, r=Zalathar
5aba379 
Rollup of 7 pull requests

Successful merges:

 - #146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
 - #147373 (give a better example why `std` modules named like primitives are needed)
 - #147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path)
 - #147457 (specialize slice::fill to use memset when possible)
 - #147468 (Implement fs api set_times and set_times_nofollow)
 - #147489 (Prefer to use repeat_n over repeat().take())
 - #147506 (compiletest: Isolate public APIs and minimize public surface area)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Oct 9, 2025
Merged
bors added a commit that referenced this pull request Oct 9, 2025
@bors
Auto merge of #147512 - Zalathar:rollup-p8kb5f7, r=Zalathar
acf2437 
Rollup of 12 pull requests

Successful merges:

 - #146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
 - #147373 (give a better example why `std` modules named like primitives are needed)
 - #147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path)
 - #147420 (Add diagnostic items for `pub mod consts` of FP types)
 - #147457 (specialize slice::fill to use memset when possible)
 - #147467 (Fix double warnings on `#[no_mangle]`)
 - #147470 (Clarify how to remediate the panic_immediate_abort error)
 - #147480 (Do not invalidate CFG caches in CtfeLimit.)
 - #147481 (format: some small cleanup)
 - #147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`)
 - #147489 (Prefer to use repeat_n over repeat().take())
 - #147506 (compiletest: Isolate public APIs and minimize public surface area)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ace0de into rust-lang:master Oct 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 9, 2025
rust-timer added a commit that referenced this pull request Oct 9, 2025
@rust-timer
Unrolled build for #147489
f12d66b 
Rollup merge of #147489 - chenyukang:yukang-prefer-repeat-n, r=Kivooeo,oli-obk

Prefer to use repeat_n over repeat().take()

More from #147464, but batch processed with `ast-grep` to find and replace.

second commit add notes for library: affaf53

r? ``@RalfJung``
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 10, 2025
@Zalathar
Rollup merge of rust-lang#147489 - chenyukang:yukang-prefer-repeat-n,…
638cd60 
… r=Kivooeo,oli-obk

Prefer to use repeat_n over repeat().take()

More from rust-lang#147464, but batch processed with `ast-grep` to find and replace.

second commit add notes for library: rust-lang@affaf53

r? ``@RalfJung``
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Oct 13, 2025
@bors
Auto merge of #147512 - Zalathar:rollup-p8kb5f7, r=Zalathar
c6ea29f 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
 - rust-lang/rust#147373 (give a better example why `std` modules named like primitives are needed)
 - rust-lang/rust#147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path)
 - rust-lang/rust#147420 (Add diagnostic items for `pub mod consts` of FP types)
 - rust-lang/rust#147457 (specialize slice::fill to use memset when possible)
 - rust-lang/rust#147467 (Fix double warnings on `#[no_mangle]`)
 - rust-lang/rust#147470 (Clarify how to remediate the panic_immediate_abort error)
 - rust-lang/rust#147480 (Do not invalidate CFG caches in CtfeLimit.)
 - rust-lang/rust#147481 (format: some small cleanup)
 - rust-lang/rust#147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`)
 - rust-lang/rust#147489 (Prefer to use repeat_n over repeat().take())
 - rust-lang/rust#147506 (compiletest: Isolate public APIs and minimize public surface area)

r? `@ghost`
`@rustbot` modify labels: rollup
@github-actions github-actions bot mentioned this pull request Oct 15, 2025
Closed
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147512 - Zalathar:rollup-p8kb5f7, r=Zalathar
ccff8fd 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
 - rust-lang/rust#147373 (give a better example why `std` modules named like primitives are needed)
 - rust-lang/rust#147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path)
 - rust-lang/rust#147420 (Add diagnostic items for `pub mod consts` of FP types)
 - rust-lang/rust#147457 (specialize slice::fill to use memset when possible)
 - rust-lang/rust#147467 (Fix double warnings on `#[no_mangle]`)
 - rust-lang/rust#147470 (Clarify how to remediate the panic_immediate_abort error)
 - rust-lang/rust#147480 (Do not invalidate CFG caches in CtfeLimit.)
 - rust-lang/rust#147481 (format: some small cleanup)
 - rust-lang/rust#147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`)
 - rust-lang/rust#147489 (Prefer to use repeat_n over repeat().take())
 - rust-lang/rust#147506 (compiletest: Isolate public APIs and minimize public surface area)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147512 - Zalathar:rollup-p8kb5f7, r=Zalathar
5461966 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
 - rust-lang/rust#147373 (give a better example why `std` modules named like primitives are needed)
 - rust-lang/rust#147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path)
 - rust-lang/rust#147420 (Add diagnostic items for `pub mod consts` of FP types)
 - rust-lang/rust#147457 (specialize slice::fill to use memset when possible)
 - rust-lang/rust#147467 (Fix double warnings on `#[no_mangle]`)
 - rust-lang/rust#147470 (Clarify how to remediate the panic_immediate_abort error)
 - rust-lang/rust#147480 (Do not invalidate CFG caches in CtfeLimit.)
 - rust-lang/rust#147481 (format: some small cleanup)
 - rust-lang/rust#147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`)
 - rust-lang/rust#147489 (Prefer to use repeat_n over repeat().take())
 - rust-lang/rust#147506 (compiletest: Isolate public APIs and minimize public surface area)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147512 - Zalathar:rollup-p8kb5f7, r=Zalathar
742a1da 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
 - rust-lang/rust#147373 (give a better example why `std` modules named like primitives are needed)
 - rust-lang/rust#147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path)
 - rust-lang/rust#147420 (Add diagnostic items for `pub mod consts` of FP types)
 - rust-lang/rust#147457 (specialize slice::fill to use memset when possible)
 - rust-lang/rust#147467 (Fix double warnings on `#[no_mangle]`)
 - rust-lang/rust#147470 (Clarify how to remediate the panic_immediate_abort error)
 - rust-lang/rust#147480 (Do not invalidate CFG caches in CtfeLimit.)
 - rust-lang/rust#147481 (format: some small cleanup)
 - rust-lang/rust#147488 (refactor: Remove `LLVMRustInsertPrivateGlobal` and `define_private_global`)
 - rust-lang/rust#147489 (Prefer to use repeat_n over repeat().take())
 - rust-lang/rust#147506 (compiletest: Isolate public APIs and minimize public surface area)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@petrochenkov petrochenkov

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@chenyukang @rustbot @RalfJung @oli-obk @bors @Kivooeo @petrochenkov