Skip to content

library/std: Rename ON_BROKEN_PIPE_FLAG_USED to ON_BROKEN_PIPE_USED#152133

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Enselic:on-broken-pipe-flag-rename
Feb 5, 2026
Merged

library/std: Rename ON_BROKEN_PIPE_FLAG_USED to ON_BROKEN_PIPE_USED#152133
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Enselic:on-broken-pipe-flag-rename

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Feb 4, 2026

This commit is a pure internal rename and does not change any functionality.

The FLAG_ part of ON_BROKEN_PIPE_FLAG_USED comes from that the compiler flag -Zon-broken-pipe=... is used to enable the feature.

Remove the FLAG_ part so the name works both for the current compiler flag -Zon-broken-pipe=... and for the upcoming Externally Implementable Item #[std::io::on_broken_pipe] PR. This makes the diff of that PR smaller.

The local variable name sigpipe_attr_specified comes from way back when the feature was controlled with an fn main() attribute called #[unix_sigpipe = "..."]. Rename that too.

This commmit is a pure rename and does not change any functionality.

The `FLAG_` part of `ON_BROKEN_PIPE_FLAG_USED` comes from that the
compiler flag `-Zon-broken-pipe=...` is used to enable the feature.

Remove the `FLAG_` part so the name works both for the flag
`-Zon-broken-pipe=...` and for the upcoming Externally Implementable
Item `#[std::io::on_broken_pipe]`. This makes the diff of that PR
smaller.

The local variable name `sigpipe_attr_specified` comes from way back
when the feature was controlled with an `fn main()` attribute called
`#[unix_sigpipe = "..."]`. Rename that too.
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 4, 2026
@Enselic Enselic marked this pull request as ready for review February 5, 2026 04:33
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ChrisDenton
Copy link
Member

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 5, 2026

📌 Commit 01c0c14 has been approved by ChrisDenton

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #150831 (c-variadic: make `va_arg` match on `Arch` exhaustive)
 - #152113 (Fix GitHub CI summary in CodeBuild)
 - #152153 (Incorporate query description functions into `QueryVTable`)
 - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`)
 - #152106 (Convert to inline diagnostics in `rustc_ast_passes`)
 - #152109 (Convert to inline diagnostics in `rustc_errors`)
 - #152119 (Convert to inline diagnostics in `rustc_middle`)
 - #152121 (Convert to inline diagnostics in `rustc_builtin_macros`)
 - #152133 (library/std: Rename `ON_BROKEN_PIPE_FLAG_USED` to `ON_BROKEN_PIPE_USED`)

Failed merges:

 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152126 (Convert to inline diagnostics in `rustc_mir_build`)
 - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
@rust-bors rust-bors bot merged commit cb77fcb into rust-lang:main Feb 5, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 5, 2026
Rollup merge of #152133 - Enselic:on-broken-pipe-flag-rename, r=ChrisDenton

library/std: Rename `ON_BROKEN_PIPE_FLAG_USED` to `ON_BROKEN_PIPE_USED`

This commit is a pure internal rename and does not change any functionality.

The `FLAG_` part of `ON_BROKEN_PIPE_FLAG_USED` comes from that the compiler flag `-Zon-broken-pipe=...` is used to enable the feature.

Remove the `FLAG_` part so the name works both for the current compiler flag `-Zon-broken-pipe=...` and for the upcoming [Externally Implementable Item `#[std::io::on_broken_pipe]`](#150591) PR. This makes the diff of that PR smaller.

The local variable name `sigpipe_attr_specified` comes from way back when the feature was controlled with an `fn main()` attribute called `#[unix_sigpipe = "..."]`. Rename that too.
@rustbot rustbot added this to the 1.95.0 milestone Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants