Rollup of 9 pull requests#152163
Merged
rust-bors[bot] merged 19 commits intorust-lang:mainfrom Feb 5, 2026
Merged
Conversation
This commmit is a pure rename and does not change any functionality. The `FLAG_` part of `ON_BROKEN_PIPE_FLAG_USED` comes from that the compiler flag `-Zon-broken-pipe=...` is used to enable the feature. Remove the `FLAG_` part so the name works both for the flag `-Zon-broken-pipe=...` and for the upcoming Externally Implementable Item `#[std::io::on_broken_pipe]`. This makes the diff of that PR smaller. The local variable name `sigpipe_attr_specified` comes from way back when the feature was controlled with an `fn main()` attribute called `#[unix_sigpipe = "..."]`. Rename that too.
…gjubilee c-variadic: make `va_arg` match on `Arch` exhaustive tracking issue: rust-lang#44930 Continuing from rust-lang#150094, the more annoying cases remain. These are mostly very niche targets without Clang `va_arg` implementations, and so it might just be easier to defer to LLVM instead of us getting the ABI subtly wrong. That does mean we cannot stabilize c-variadic on those targets I think. Alternatively we could ask target maintainers to contribute an implementation. I'd honestly prefer they make that change to LVM though (likely by just using `CodeGen::emitVoidPtrVAArg`) that we can mirror. r? @workingjubilee
…rcoieni Fix GitHub CI summary in CodeBuild We need to copy the summary only after the data is copied out from the Docker image in Docker-in-Docker/CodeBuild scenarios. This was broken for many months now. Compare the summary https://github.com/rust-lang/rust/actions/runs/21663321354 (before) and https://github.com/rust-lang/rust/actions/runs/21671277310 (after) - the dist-x86_64-linux job now correctly contains the summary generated by `opt-dist`. r? @marcoieni
Incorporate query description functions into `QueryVTable` Putting a `desc` function in each query vtable reduces the amount of parameter juggling required when creating query stack frames, because almost all of the necessary information can be found in the vtable. There should be no change to compiler output.
…alysis, r=jdonszelmann Convert to inline diagnostics in `rustc_pattern_analysis` For rust-lang#151366 r? @jdonszelmann
…, r=jdonszelmann Convert to inline diagnostics in `rustc_ast_passes` For rust-lang#151366 r? @jdonszelmann
Convert to inline diagnostics in `rustc_errors` For rust-lang#151366 r? @jdonszelmann
…jdonszelmann Convert to inline diagnostics in `rustc_middle` For rust-lang#151366 r? @jdonszelmann
…cros, r=lqd Convert to inline diagnostics in `rustc_builtin_macros` For rust-lang#151366 r? @jdonszelmann
…, r=ChrisDenton library/std: Rename `ON_BROKEN_PIPE_FLAG_USED` to `ON_BROKEN_PIPE_USED` This commit is a pure internal rename and does not change any functionality. The `FLAG_` part of `ON_BROKEN_PIPE_FLAG_USED` comes from that the compiler flag `-Zon-broken-pipe=...` is used to enable the feature. Remove the `FLAG_` part so the name works both for the current compiler flag `-Zon-broken-pipe=...` and for the upcoming [Externally Implementable Item `#[std::io::on_broken_pipe]`](rust-lang#150591) PR. This makes the diff of that PR smaller. The local variable name `sigpipe_attr_specified` comes from way back when the feature was controlled with an `fn main()` attribute called `#[unix_sigpipe = "..."]`. Rename that too.
rustbot
added
A-CI
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
bot
added
merged-by-bors
Contributor
This was referenced Feb 5, 2026
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 0a13b43612 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 0a13b43 (parent) -> 66daca1 (this PR) Test differencesShow 406 test diffsStage 0
Stage 1
(and 296 additional test diffs) Additionally, 10 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 66daca1a85c459b1da49dc0ef1ba027b53e4ac2c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Feb 5, 2026
Draft
Collaborator
|
Finished benchmarking commit (66daca1): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.495s -> 474.029s (-0.10%) |
Contributor
Author
|
This is a very similar perf improvement pattern to #152156 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
va_argmatch onArchexhaustive #150831 (c-variadic: makeva_argmatch onArchexhaustive)QueryVTable#152153 (Incorporate query description functions intoQueryVTable)rustc_pattern_analysis#152070 (Convert to inline diagnostics inrustc_pattern_analysis)rustc_ast_passes#152106 (Convert to inline diagnostics inrustc_ast_passes)rustc_errors#152109 (Convert to inline diagnostics inrustc_errors)rustc_middle#152119 (Convert to inline diagnostics inrustc_middle)rustc_builtin_macros#152121 (Convert to inline diagnostics inrustc_builtin_macros)ON_BROKEN_PIPE_FLAG_USEDtoON_BROKEN_PIPE_USED#152133 (library/std: RenameON_BROKEN_PIPE_FLAG_USEDtoON_BROKEN_PIPE_USED)Failed merges:
rustc_borrowck#152107 (Convert to inline diagnostics inrustc_borrowck)rustc_trait_selection#152117 (Convert to inline diagnostics inrustc_trait_selection)rustc_mir_build#152126 (Convert to inline diagnostics inrustc_mir_build)r? @ghost
Create a similar rollup