Convert to inline diagnostics in `rustc_hir_typeck`#152142

JonathanBrouwer · 2026-02-04T20:37:30Z

For #151366
r? @GuillaumeGomez

GuillaumeGomez · 2026-02-04T21:59:19Z

Looks good to me, thanks! r=me once CI pass

JonathanBrouwer · 2026-02-04T22:05:26Z

@bors r=GuillaumeGomez

rust-bors · 2026-02-04T22:05:29Z

📌 Commit 44a14c1 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@GuillaumeGomez

…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez

Rollup of 15 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #146900 (Add avr_target_feature) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

@GuillaumeGomez

…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez

@GuillaumeGomez

…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez

Rollup of 19 pull requests Successful merges: - #146900 (Add avr_target_feature) - #150379 (Return `ExitCode` from `rustc_driver::main` instead of calling `process::exit`) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152145 (Disable flaky test `oneshot::recv_timeout_before_send`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152110 (Fix incorrect RSS on systems with non-4K page size) - #152111 (bootstrap: exclude hexagon-unknown-qurt from llvm-libunwind default) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

…uwer Rollup of 18 pull requests Successful merges: - #150379 (Return `ExitCode` from `rustc_driver::main` instead of calling `process::exit`) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152145 (Disable flaky test `oneshot::recv_timeout_before_send`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152110 (Fix incorrect RSS on systems with non-4K page size) - #152111 (bootstrap: exclude hexagon-unknown-qurt from llvm-libunwind default) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

@GuillaumeGomez

Rollup merge of #152142 - JonathanBrouwer:convert_hir_typeck, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For #151366 r? @GuillaumeGomez

JonathanBrouwer · 2026-02-05T14:48:29Z

@rust-timer build f767a88

rust-timer · 2026-02-05T16:09:43Z

Finished benchmarking commit (f767a88): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-1.1%, -0.2%]	12
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.0%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

Results (secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.797s -> 476.586s (0.38%)
Artifact size: 397.94 MiB -> 397.91 MiB (-0.01%)

Convert to inline diagnostics in rustc_hir_typeck

44a14c1

rustbot assigned GuillaumeGomez Feb 4, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026

JonathanBrouwer mentioned this pull request Feb 4, 2026

Tracking issue for MCP 959: Remove the fluent files #151366

Open

5 tasks

GuillaumeGomez approved these changes Feb 4, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026

Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 5, 2026

Rollup merge of rust-lang#152142 - JonathanBrouwer:convert_hir_typeck…

29a4a4a

…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez

Zalathar mentioned this pull request Feb 5, 2026

Rollup of 15 pull requests #152144

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 5, 2026

Rollup merge of rust-lang#152142 - JonathanBrouwer:convert_hir_typeck…

1fb1d9c

…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez

Zalathar mentioned this pull request Feb 5, 2026

Rollup of 18 pull requests #152147

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 5, 2026

Rollup merge of rust-lang#152142 - JonathanBrouwer:convert_hir_typeck…

0e525c5

…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez

Zalathar mentioned this pull request Feb 5, 2026

Rollup of 19 pull requests #152149

Closed

JonathanBrouwer mentioned this pull request Feb 5, 2026

Rollup of 18 pull requests #152156

Merged

rust-bors bot merged commit 775ae61 into rust-lang:main Feb 5, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 5, 2026

rust-timer added a commit that referenced this pull request Feb 5, 2026

Unrolled build for #152142

f767a88

Rollup merge of #152142 - JonathanBrouwer:convert_hir_typeck, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For #151366 r? @GuillaumeGomez

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convert to inline diagnostics in `rustc_hir_typeck`#152142