Closed
Conversation
There don't appear to be any trait impls relying on this default body.
After http://github.com/llvm/llvm-project/pull/178977, the and + icmp are folded to trunc.
Also remove mentions of removed `rustc_dirty`
It's a tiny module with one trait and a default impl. It's not used in `rustc_query_system`; all uses and non-default impls are in `rustc_middle` and `rustc_query_impl`. This commit moves it into `rustc_middle`, which makes things simpler overall.
It's a better place for it, because it relates to queries.
They are defined in `rustc_query_system` but used in `rustc_query_impl`. This is very much *not* how things are supposed to be done; I suspect someone got lazy and took a shortcut at some point. This commit moves the errors into `rustc_query_impl`. This requires more lines of code to give `rustc_query_impl` an errors module, but it's worthwhile to do things in the normal way instead of a weird exceptional way.
It's unused. And it's nice to remove this function that didn't behave like normal `clear` does, as the comment explained.
…nathanBrouwer Add new unstable attribute: `#[export_visibility = ...]`. This PR is an implementation of the RFC tracked in rust-lang#151425
…ingjubilee Add avr_target_feature This adds the following unstable target features (tracking issue: rust-lang#146889): - The following two are particularly important for properly supporting inline assembly: - `tinyencoding`: AVR has devices that reduce the number of registers, similar to RISC-V's RV32E. This feature is necessary to support inline assembly in such devices. (see also rust-lang#146901) - `lowbytefirst`: AVR's memory access is per 8-bit, and when writing 16-bit ports, the bytes must be written in a specific order. This order depends on devices, making this feature necessary to write proper inline assembly for such use cases. (see also llvm/llvm-project@2a52876) - The followings help recognizing whether specific instructions are available: - `addsubiw` - `break` - `eijmpcall` - `elpm` - `elpmx` - `ijmpcall` - `jmpcall` - `lpm` - `lpmx` - `movw` - `mul` - `rmw` - `spm` - `spmx` Of these, all except `addsubiw`, `break`, `ijmpcall`, `lpm`, `rmw`, `spm`, and `spmx` have [corresponding conditional codes in avr-libc](https://github.com/search?q=repo%3Aavrdudes%2Favr-libc+%2F__AVR_HAVE_%2F&type=code&p=1). LLVM also has `des` feature, but I excluded it from this PR because [DES](https://en.wikipedia.org/wiki/Data_Encryption_Standard) is insecure. - Report future-incompatible warning (rust-lang#116344) for -C target-feature=-sram and -C target-cpu=<device_without_sram> cases because SRAM is minimum requirement for non-assembly language in both avr-gcc and LLVM. - See rust-lang#146900 (comment) for details. LLVM also has `smallstack`, `wrappingrjmp`, and `memmappedregs` features, but I skipped them because they didn't seem to belong to either of the above categories, but I might have missed something. (The feature names are match with [definitions in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-21.1.0/llvm/lib/Target/AVR/AVRDevices.td).) cc @Patryk27 @Rahix r? workingjubilee @rustbot label +O-AVR +A-target-feature
Rename trait `DepNodeParams` to `DepNodeKey` In query system plumbing, we usually refer to a query's explicit argument value as a “key”. The first few commits do some preliminary cleanup that would conflict with the rename; the rename itself is in the final commit. r? nnethercote (or compiler)
…, r=GuillaumeGomez Convert to inline diagnostics in `rustc_hir_typeck` For rust-lang#151366 r? @GuillaumeGomez
… r=ZuseZ4 Remove dummy loads on offload codegen The current logic generates two dummy loads to prevent some globals from being optimized away. This blocks memtransfer loop hoisting optimizations, so it's time to remove them. r? @ZuseZ4
Some `rustc_query_system` cleanups Small improvements I found while looking closely at `rustc_query_system`. Best reviewed one commit at a time. r? @cjgillot
…r=nikic Adopt matches-logical-or-141497.rs to LLVM HEAD After http://github.com/llvm/llvm-project/pull/178977, the and + icmp are folded to trunc.
rustbot
added
A-attributes
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
Rollup of 15 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #146900 (Add avr_target_feature) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for 491664b failed: CI. Failed job:
|
rust-bors
bot
added
S-waiting-on-author
Contributor
|
PR #151431, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[export_visibility = ...]. #151431 (Add new unstable attribute:#[export_visibility = ...].)DepNodeParamstoDepNodeKey#152033 (Rename traitDepNodeParamstoDepNodeKey)rustc_hir_typeck#152142 (Convert to inline diagnostics inrustc_hir_typeck)rustc_query_systemcleanups #152023 (Somerustc_query_systemcleanups)rustc_resolve#152068 (Convert to inline diagnostics inrustc_resolve)rustc_ast_lowering#152105 (Convert to inline diagnostics inrustc_ast_lowering)rustc_expand#152108 (Convert to inline diagnostics inrustc_expand)rustc_mir_transform#152114 (Convert to inline diagnostics inrustc_mir_transform)rustc_metadata#152115 (Convert to inline diagnostics inrustc_metadata)Failed merges:
rustc_pattern_analysis#152070 (Convert to inline diagnostics inrustc_pattern_analysis)rustc_ast_passes#152106 (Convert to inline diagnostics inrustc_ast_passes)rustc_errors#152109 (Convert to inline diagnostics inrustc_errors)rustc_trait_selection#152117 (Convert to inline diagnostics inrustc_trait_selection)rustc_codegen_ssa#152118 (Convert to inline diagnostics inrustc_codegen_ssa)rustc_middle#152119 (Convert to inline diagnostics inrustc_middle)rustc_mir_build#152126 (Convert to inline diagnostics inrustc_mir_build)r? @ghost
Create a similar rollup