Conversation
|
@petrochenkov those are still necessary since none of the Bitrig changes have been upstreamed. I'm surprised about the OpenBSD shared library part of the patch. @semarie is that still necessary? |
Member
|
@bors: r+ 0ef8afdf05556840c48d8c9c71b8ac149259624f |
bors
added a commit
that referenced
this pull request
Jan 15, 2016
New: Fix for rust-lang#28447 Merged: openbsd support: rust-lang@fcb30a0 bitrig integration: rust-lang@cd8f317 Not merged: rust-lang@d4fc3ec @Diggsey says this change was unintended (rust-lang#30666 (comment))
petrochenkov
force-pushed
the
backtrace
branch
from
0ef8afd to
55e2b7e
Compare
Contributor
Author
|
Updated with a fix for #28447 The reason was a pretty silly mistake in 4-byte length of COFF string table was read like this: After this initialization half of |
Member
Contributor
Author
|
@alexcrichton |
Member
|
Nice! |
bors
added a commit
that referenced
this pull request
Jan 16, 2016
@dhuseby @semarie Please, confirm that all Rust-specific changes in the second commit are still required. (It would be ideal to have an unpatched copy of libbacktrace straight from the gcc repo.) Fixes #28447 r? @alexcrichton
Collaborator
Collaborator
Contributor
|
If only it had been written in rust... |
Contributor
Contributor
Author
|
@ranma42 |
alexcrichton
added a commit
to alexcrichton/libbacktrace
that referenced
this pull request
Jul 25, 2017
This updates the local declaration of `str_size` to always be 4 bytes instead of platform-dependent as its initialization later on only fills in 4 bytes instead of all the bytes of `size_t`. Originally reported as rust-lang/rust#28447 this was fixed in rust-lang/rust#30908
Merged
bors
added a commit
that referenced
this pull request
May 30, 2018
Update libbacktrace We haven't updated libbacktrace in two years. This is just blindly updating to the latest HEAD; I'd like to see what travis says. It at least builds on my machine, running some tests... This perpetuates the patches from #30908
dscho
pushed a commit
to dscho/libbacktrace
that referenced
this pull request
Jul 18, 2022
This updates the local declaration of `str_size` to always be 4 bytes instead of platform-dependent as its initialization later on only fills in 4 bytes instead of all the bytes of `size_t`. Originally reported as rust-lang/rust#28447 this was fixed in rust-lang/rust#30908
johnsonjh
added a commit
to johnsonjh/libbacktrace
that referenced
this pull request
Oct 18, 2022
… of uninitialized bytes in pecoff.c; 3) Fix a use of undefined memory in pecoff.c 1) Note: as we target MINGW here, we still want to look up the symbols via the DWARF method (the native Windows way would be to call the SymFromAddr() function, but that would require .pdb files which MINGW does not produce). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> 2) This updates the local declaration of `str_size` to always be 4 bytes instead of platform-dependent as its initialization later on only fills in 4 bytes instead of all the bytes of `size_t`. Originally reported as rust-lang/rust#28447 this was fixed in rust-lang/rust#30908 3) In rust-lang/rust#39468 it was discovered that this could cause a crash in libbacktrace due to freeing uninitialized memory, and this specific instance was fixed in rust-lang/rust#39509
dscho
pushed a commit
to dscho/libbacktrace
that referenced
this pull request
Apr 8, 2024
This updates the local declaration of `str_size` to always be 4 bytes instead of platform-dependent as its initialization later on only fills in 4 bytes instead of all the bytes of `size_t`. Originally reported as rust-lang/rust#28447 this was fixed in rust-lang/rust#30908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dhuseby @semarie Please, confirm that all Rust-specific changes in the second commit are still required.
(It would be ideal to have an unpatched copy of libbacktrace straight from the gcc repo.)
Fixes #28447
r? @alexcrichton