update blksize_t in raw to reflect libc change under openbsd#30925
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 15, 2016
Merged
update blksize_t in raw to reflect libc change under openbsd#30925bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
Member
|
@bors: rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 15, 2016
make `os::raw::tests::unix` test to pass again r? @alexcrichton
bors
added a commit
that referenced
this pull request
Jan 15, 2016
Contributor
|
I just wanted to check in on this: we had mega problems making a similar change on Android, which was similarly considered having non-first tier support. Are we confident this won't instigate the same sort of breakage and dependency hell we saw there? |
Contributor
Author
|
@aturon I am not sure to exactly understand the question. Some days ago, I updated OpenBSD Rust-libc based on libc-test (test suite of libc), and checking the C code. It results several code update to adjust Rust-libc with C-libc (see rust-lang/libc#110 for all changes).
|
Member
|
@aturon yes I suspect this to have far less breakage for two reasons:
I suspect it won't take long to mitigate any breakage that comes up, even if it does so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make
os::raw::tests::unixtest to pass againr? @alexcrichton