Conversation
We originally imported this into the repository with the intent of fixing it up. Instead, nothing happened. Its appearance on rust-lang.org makes it seem semi-official, but it's not. The rustfmt strike team will end up producing something like this anyway, and leaving it around does nothing but mislead people.
steveklabnik
force-pushed
the
remove_style
branch
from
cbb6abd to
57719e2
Compare
Contributor
|
Hm, I thought I commented on this here before, but: r=me. To be clear, the API style guide won't be covered by the strike team, but it's something the libs team should work on and make more official. I'm fine removing this for now. |
Contributor
Author
|
@bors: r=aturon rollup (we talked about it briefly on IRC, that's why you remember saying something. I had forgotten to actually take care of it, though) |
Collaborator
|
📌 Commit 57719e2 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 26, 2016
Remove style guide. We originally imported this into the repository with the intent of fixing it up. Instead, nothing happened. Its appearance on rust-lang.org makes it seem semi-official, but it's not. The rustfmt strike team will end up producing something like this anyway, and leaving it around does nothing but mislead people. r? @aturon
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 27, 2016
Remove style guide. We originally imported this into the repository with the intent of fixing it up. Instead, nothing happened. Its appearance on rust-lang.org makes it seem semi-official, but it's not. The rustfmt strike team will end up producing something like this anyway, and leaving it around does nothing but mislead people. r? @aturon
Member
|
Needs 96d523d |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 27, 2016
bors
added a commit
that referenced
this pull request
Aug 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We originally imported this into the repository with the intent of
fixing it up. Instead, nothing happened.
Its appearance on rust-lang.org makes it seem semi-official, but it's
not. The rustfmt strike team will end up producing something like this
anyway, and leaving it around does nothing but mislead people.
r? @aturon