Improve error message when failing to parse a block#35953
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 27, 2016
Merged
Improve error message when failing to parse a block#35953bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
We want to catch this error:
```
if (foo)
bar;
```
as it's valid syntax in other languages, and say how to fix it.
Unfortunately it didn't care if the suggestion made sense and just
highlighted the unexpected token.
Now it attempts to parse a statement, and if it succeeds, it shows the
help message.
Fixes rust-lang#35907
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
Could you file an issue to add a template --explain error thing here please? @bors: r+ |
Collaborator
|
📌 Commit 72d629c has been approved by |
Collaborator
|
⌛ Testing commit 72d629c with merge 613fd2b... |
Collaborator
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
Contributor
|
@bors retry |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 27, 2016
…=nrc
Improve error message when failing to parse a block
We want to catch this error:
```
if (foo)
bar;
```
as it's valid syntax in other languages, and say how to fix it.
Unfortunately it didn't care if the suggestion made sense and just
highlighted the unexpected token.
Now it attempts to parse a statement, and if it succeeds, it shows the
help message.
Fixes rust-lang#35907
bors
added a commit
that referenced
this pull request
Aug 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to catch this error:
as it's valid syntax in other languages, and say how to fix it.
Unfortunately it didn't care if the suggestion made sense and just
highlighted the unexpected token.
Now it attempts to parse a statement, and if it succeeds, it shows the
help message.
Fixes #35907