incr.comp.: Minor refactoring and update to struct ICH test case#36831
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 13, 2016
Merged
incr.comp.: Minor refactoring and update to struct ICH test case#36831bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Member
Author
There was a problem hiding this comment.
Maybe? :) I sometimes like to have the extra space there because it makes things easier to read.
Member
There was a problem hiding this comment.
Most of the other impls in this file (and across the compiler) don't have it. "Ask the style team." (not that there are concrete answers there at this point either).
Member
Author
There was a problem hiding this comment.
Yeah, I'll change it.
michaelwoerister
force-pushed
the
ich-updates
branch
from
e824625 to
7ab5660
Compare
Collaborator
|
☔ The latest upstream changes (presumably #36815) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoerister
force-pushed
the
ich-updates
branch
from
7ab5660 to
954d89b
Compare
Member
Author
|
Rebased. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 954d89b has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 12, 2016
…omatsakis incr.comp.: Minor refactoring and update to struct ICH test case r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Oct 12, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis