Add invalid doc comment help message#36964

GuillaumeGomez · 2016-10-04T17:11:19Z

Any opinion on the message?

rust-highfive · 2016-10-04T17:11:47Z

(rust_highfive has picked a reviewer for you, use r? to override)

solson · 2016-10-04T22:51:38Z

src/libsyntax/feature_gate.rs

I would instead make a version of this function (say, feature_err) that returns the err instead of calling err.emit(), and have this function just do feature_err(...).emit(). Then the existing callers of this function don't need to change for the None argument, and the stmt_expr_attributes one can do let err = feature_err(...); err.help(...); err.emit();.

solson · 2016-10-04T22:53:13Z

src/libsyntax/config.rs

I would say something like

`///` is for documentation comments. For a plain comment, use `//`.

Won't this help trigger for all misplaced attributes? It should only trigger for misplaced doc attributes.

bors · 2016-10-07T18:40:02Z

☔ The latest upstream changes (presumably #36945) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2016-10-08T18:05:20Z

Updated.

solson

Looks good to me!

GuillaumeGomez · 2016-10-09T10:42:58Z

We now need a reviewer. cc @jonathandturner :p

solson · 2016-10-09T10:46:14Z

src/libsyntax/config.rs

Oh, I forgot to bring this up again.

This help should only be generated for misplaced doc comments, but this will generate it for any misplaced attributes at all.

@solson - sounds like an interesting point. @GuillaumeGomez ?

Didn't think of testing in other cases. Good point! I'll check a bit later.

frewsxcv · 2016-10-11T21:33:39Z

src/libsyntax/feature_gate.rs

Nit: indentation is off here

GuillaumeGomez · 2016-10-18T20:40:18Z

Updated.

sophiajt · 2016-10-18T21:40:29Z

@bors r+ rollup

bors · 2016-10-18T21:40:30Z

📌 Commit 93417fa has been approved by jonathandturner

…athandturner Add invalid doc comment help message Fixes rust-lang#36946. Any opinion on the message?

Rollup of 23 pull requests - Successful merges: #36964, #37108, #37117, #37124, #37161, #37176, #37182, #37193, #37198, #37202, #37208, #37218, #37221, #37224, #37230, #37231, #37233, #37236, #37240, #37254, #37257, #37265, #37267 - Failed merges: #37213, #37220, #37261

rust-highfive assigned pnkfelix Oct 4, 2016

solson reviewed Oct 4, 2016

View reviewed changes

GuillaumeGomez force-pushed the comment_error branch from 2da209d to aad86c0 Compare October 8, 2016 18:05

solson approved these changes Oct 8, 2016

View reviewed changes

solson suggested changes Oct 9, 2016

View reviewed changes

frewsxcv reviewed Oct 11, 2016

View reviewed changes

src/libsyntax/feature_gate.rs Outdated

Copy link

Contributor

frewsxcv Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: indentation is off here

Add invalid doc comment help message

93417fa

GuillaumeGomez force-pushed the comment_error branch from aad86c0 to 93417fa Compare October 18, 2016 20:39

eddyb mentioned this pull request Oct 18, 2016

Rollup of 16 pull requests #37262

Closed

eddyb added a commit to eddyb/rust that referenced this pull request Oct 19, 2016

Rollup merge of rust-lang#36964 - GuillaumeGomez:comment_error, r=jon…

c98211d

…athandturner Add invalid doc comment help message Fixes rust-lang#36946. Any opinion on the message?

eddyb added a commit to eddyb/rust that referenced this pull request Oct 19, 2016

Rollup merge of rust-lang#36964 - GuillaumeGomez:comment_error, r=jon…

fdcdcac

…athandturner Add invalid doc comment help message Fixes rust-lang#36946. Any opinion on the message?

eddyb mentioned this pull request Oct 19, 2016

Rollup of 23 pull requests #37269

Merged

bors merged commit 93417fa into rust-lang:master Oct 19, 2016

GuillaumeGomez deleted the comment_error branch October 19, 2016 13:33

Uh oh!

Conversation

GuillaumeGomez commented Oct 4, 2016

Uh oh!

rust-highfive commented Oct 4, 2016

Uh oh!

solson Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solson Oct 4, 2016

Choose a reason for hiding this comment

Uh oh!

solson Oct 4, 2016

Choose a reason for hiding this comment

Uh oh!

bors commented Oct 7, 2016

Uh oh!

GuillaumeGomez commented Oct 8, 2016

Uh oh!

solson left a comment

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 9, 2016

Uh oh!

solson Oct 9, 2016

Choose a reason for hiding this comment

Uh oh!

sophiajt Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Oct 12, 2016

Choose a reason for hiding this comment

Uh oh!

frewsxcv Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 18, 2016

Uh oh!

sophiajt commented Oct 18, 2016

Uh oh!

bors commented Oct 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

solson Oct 4, 2016 •

edited

Loading