[Obligation Forest] Don't process cycles when stalled#37231
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 19, 2016
jonas-schievink:obligation-forest-the-quest-for-performance
Merged
[Obligation Forest] Don't process cycles when stalled#37231bors merged 2 commits intorust-lang:masterfrom jonas-schievink:obligation-forest-the-quest-for-performance
bors merged 2 commits intorust-lang:masterfrom
jonas-schievink:obligation-forest-the-quest-for-performance
Conversation
This improves the `inflate-0.1.0` benchmark by about 10% for me.
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
That's the change I was talking about with @nnethercote @bors r+ |
Collaborator
|
📌 Commit 88fde7f has been approved by |
Contributor
Author
|
According to Travis, it makes this test fail |
Contributor
|
That's what we have the tests for. Add @bors r- |
Contributor
Author
|
It's probably because error nodes are handled like popped nodes, so we'd have to compress when an obligation errors. |
Contributor
|
Sure 'bout that. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 0c844d2 has been approved by |
Contributor
|
I just measured a stage1 compiler with compare.py and got this: Nice! |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Oct 19, 2016
…he-quest-for-performance, r=arielb1 [Obligation Forest] Don't process cycles when stalled This improves the `inflate-0.1.0` benchmark by about 10% for me. /me hopes this is sound
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Oct 19, 2016
…he-quest-for-performance, r=arielb1 [Obligation Forest] Don't process cycles when stalled This improves the `inflate-0.1.0` benchmark by about 10% for me. /me hopes this is sound
jonas-schievink
deleted the
obligation-forest-the-quest-for-performance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the
inflate-0.1.0benchmark by about 10% for me./me hopes this is sound