Conversation
use syntax::ast::Name; is a reexport of syntax::symbol::Symbol(u32);
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
dns2utf8
commented
Nov 27, 2016
src/libsyntax/symbol.rs
Outdated
| pub fn invalid() -> Self { | ||
| Symbol(0u32) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I had to create this method because Symbol.0 is private. Is this ok?
Contributor
There was a problem hiding this comment.
Symbol(0) is already available as keywords::Invalid
Contributor
There was a problem hiding this comment.
keywords::Invalid.name() to be precise
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 28b64dc has been approved by |
dns2utf8
added a commit
to dns2utf8/rust
that referenced
this pull request
Dec 1, 2016
Fix verify.rs Finishing d2f8fb0 from @jseyfried
Closed
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Dec 3, 2016
Fix verify.rs Finishing d2f8fb0 from @jseyfried
bors
added a commit
that referenced
this pull request
Dec 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing d2f8fb0 from @jseyfried