Show `Trait` instead of `<Struct as Trait>` in E0323#38065

estebank · 2016-11-29T02:00:40Z

For a given file

trait Foo {
    fn bar(&self);
}

pub struct FooConstForMethod;

impl Foo for FooConstForMethod {
    const bar: u64 = 1;
}

show

error[E0323]: item `bar` is an associated const, which doesn't match its trait `Foo`

instead of

error[E0323]: item `bar` is an associated const, which doesn't match its trait `<FooConstForMethod as Foo>`

Fix #37618

For a given file ``` trait Foo { fn bar(&self); } pub struct FooConstForMethod; impl Foo for FooConstForMethod { const bar: u64 = 1; } ``` show ``` error[E0323]: item `bar` is an associated const, which doesn't match its trait `Foo` ``` instead of ``` error[E0323]: item `bar` is an associated const, which doesn't match its trait `<FooConstForMethod as Foo>` ```

rust-highfive · 2016-11-29T02:00:46Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2016-11-29T02:03:40Z

/cc @nikomatsakis as per your comment in a previous PR

Not related to this PR, I think, but this text "<FooConstForMethod as Foo>" seems pretty funny to me; I expect to see just Foo... is there an open issue on that?

Now there is one and here's the fix.

estebank · 2016-12-01T17:51:10Z

r? @jonathandturner

sophiajt · 2016-12-01T22:52:23Z

Yeah, looks cleaner to me.

@bors r+ rollup

bors · 2016-12-01T22:52:24Z

📌 Commit 4226930 has been approved by jonathandturner

Show `Trait` instead of `<Struct as Trait>` in E0323 For a given file ``` trait Foo { fn bar(&self); } pub struct FooConstForMethod; impl Foo for FooConstForMethod { const bar: u64 = 1; } ``` show ``` error[E0323]: item `bar` is an associated const, which doesn't match its trait `Foo` ``` instead of ``` error[E0323]: item `bar` is an associated const, which doesn't match its trait `<FooConstForMethod as Foo>` ``` Fix rust-lang#37618

Rollup of 15 pull requests - Successful merges: #37859, #37919, #38020, #38028, #38029, #38065, #38073, #38077, #38089, #38090, #38096, #38112, #38113, #38130, #38141 - Failed merges:

rust-highfive assigned arielb1 Nov 29, 2016

rust-highfive assigned sophiajt and unassigned arielb1 Dec 1, 2016

frewsxcv mentioned this pull request Dec 3, 2016

Rollup of 15 pull requests #38148

Merged

bors merged commit 4226930 into rust-lang:master Dec 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show `Trait` instead of `<Struct as Trait>` in E0323#38065