Skip to content

Clarify phrasing of MSYS2 dependencies in README.md.#38517

Merged
bors merged 1 commit intorust-lang:masterfrom
frewsxcv:clarify-msys2-dependencies
Dec 30, 2016
Merged

Clarify phrasing of MSYS2 dependencies in README.md.#38517
bors merged 1 commit intorust-lang:masterfrom
frewsxcv:clarify-msys2-dependencies

Conversation

@frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Dec 21, 2016

Fixes #36115.

@rust-highfive
Copy link
Contributor

rust-highfive commented Dec 21, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Dec 21, 2016

cc @barik @petrochenkov @alexcrichton

retep998
retep998 reviewed Dec 21, 2016
View reviewed changes
README.md Outdated
Copy link
Contributor

@retep998 retep998 Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the bold on "not" removed?

Copy link
Contributor Author

@frewsxcv frewsxcv Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional. Reverted back.

petrochenkov
petrochenkov reviewed Dec 21, 2016
View reviewed changes
README.md Outdated
Copy link
Contributor

@petrochenkov petrochenkov Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't seem to work in

code

block (see the preview).

Copy link
Contributor Author

@frewsxcv frewsxcv Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, this is a code block. Removed the link.

@frewsxcv frewsxcv force-pushed the clarify-msys2-dependencies branch 2 times, most recently from 215977a to efbdcb0 Compare December 21, 2016 22:17
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Dec 21, 2016

Comments have been addressed.

@frewsxcv frewsxcv force-pushed the clarify-msys2-dependencies branch from efbdcb0 to 273cc30 Compare December 21, 2016 22:22
@alexcrichton
Copy link
Member

alexcrichton commented Dec 25, 2016

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Dec 25, 2016

📌 Commit 273cc30 has been approved by alexcrichton

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Dec 26, 2016

@bors rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton
Rollup merge of rust-lang#38517 - frewsxcv:clarify-msys2-dependencies…
4e2e01e 
…, r=alexcrichton

Clarify phrasing of MSYS2 dependencies in README.md.

Fixes rust-lang#36115.
@alexcrichton alexcrichton mentioned this pull request Dec 30, 2016
Merged
bors added a commit that referenced this pull request Dec 30, 2016
@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
7f2d2af 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
@bors bors merged commit 273cc30 into rust-lang:master Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

+1 more reviewer

@retep998 retep998 retep998 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakis nikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@frewsxcv @rust-highfive @alexcrichton @bors @retep998 @petrochenkov @nikomatsakis