rustbuild: allow overriding list of LLVM targets to build#38657

xen0n · 2016-12-28T18:32:07Z

Here we go!

A new option is introduced under the `[llvm]` section of `config.toml`, `targets`, for overriding the list of LLVM targets to build support for. The option is passed through to LLVM configure script. Also notes are added about the implications of (ab)using the option; since the default is not changed, and users of the option are expected to know what they're doing anyway (as every porter should), the impact should be minimal. Fixes rust-lang#38200.

hanna-kruppe · 2016-12-28T18:44:26Z

src/bootstrap/native.rs

        (true, true) => "RelWithDebInfo",
    };

+    // NOTE: remember to also update `config.toml.example` when changing the defaults!


Yamakaky · 2016-12-29T03:07:32Z

Cool!

xen0n · 2016-12-29T04:53:57Z

Wait there's the problem of stale cache when the target list has been changed. Most likely we'd like to revamp the current stamping logic to include the targets also, maybe ditching the date part altogether. I'll come up with something like that later in the day.

alexcrichton · 2016-12-29T07:28:09Z

@bors: r+

Looks good to me! I don't think we have to worry too much about stale issues here, presumably you know what you're doing if you're tweaking this configuration.

bors · 2016-12-29T07:28:10Z

📌 Commit 0f8e931 has been approved by alexcrichton

Yamakaky · 2016-12-29T14:25:09Z

Auto-rebuild would be cool though.

xen0n · 2016-12-29T14:29:54Z

@Yamakaky I've already implemented that in a local branch. Waiting for this PR to land, then I could publish it for review as it's directly built upon this PR.

Rollup of 25 pull requests - Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695 - Failed merges: #38657, #38680

rust-highfive assigned alexcrichton Dec 28, 2016

hanna-kruppe reviewed Dec 28, 2016

View reviewed changes

alexcrichton mentioned this pull request Dec 30, 2016

Rollup of 25 pull requests #38697

Merged

bors merged commit 0f8e931 into rust-lang:master Dec 30, 2016

xen0n deleted the rustbuild-llvm-targets branch December 30, 2016 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustbuild: allow overriding list of LLVM targets to build#38657