Document that std::hash::Hasher::finish() does not reset the hasher.#43905
Document that std::hash::Hasher::finish() does not reset the hasher.#43905bors merged 1 commit intorust-lang:masterfrom partim:master
std::hash::Hasher::finish() does not reset the hasher.#43905Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@rust-lang/libs I want to make sure this is a feature, not a bug. These docs look good to me, so as long as yinz sign off on it, r=me |
|
IIRC this was the intention, yes. Thanks for the PR @partim! |
|
@bors: r+ rollup great, thank you! |
|
📌 Commit 02aaa11 has been approved by |
Document that `std::hash::Hasher::finish()` does not reset the hasher. Clarifies the fact that `finish()` doesn’t in fact end or reset the hasher. This was surprising to me … Follows up on and fixes rust-lang#43763
Clarifies the fact that
finish()doesn’t in fact end or reset the hasher. This was surprising to me …Follows up on and fixes #43763