Skip to content

E0106: field lifetimes#43912

Merged
bors merged 2 commits intorust-lang:masterfrom
Songbird0:e0106_field_lifetimes
Aug 17, 2017
Merged

E0106: field lifetimes#43912
bors merged 2 commits intorust-lang:masterfrom
Songbird0:e0106_field_lifetimes

Conversation

@Songbird0
Copy link
Contributor

@Songbird0 Songbird0 commented Aug 16, 2017 •
edited
Loading

Hi there,

I've added an example for custom type lifetimes located in another struct field.

cc @GuillaumeGomez

@Songbird0
E0106: field lifetimes
fe06b70 
I've added an example for custom type lifetimes located in another `struct` fields.
@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 16, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Aug 16, 2017
View reviewed changes
src/librustc/diagnostics.rs Outdated
struct Foo { x: &bool } // error
struct Foo<'a> { x: &'a bool } // correct

struct Bar{ x: Foo }
Copy link
Member

@GuillaumeGomez GuillaumeGomez Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a whitespace before a {.

GuillaumeGomez
GuillaumeGomez reviewed Aug 16, 2017
View reviewed changes
src/librustc/diagnostics.rs Outdated

struct Bar{ x: Foo }
^^^ expected lifetime parameter
struct Bar<'a>{ x: Foo<'a> } // correct
Copy link
Member

@GuillaumeGomez GuillaumeGomez Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 16, 2017

Once this fixed, it'll be good. Thanks for your contribution!

@aidanhs aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 16, 2017
@Songbird0
Copy link
Contributor Author

Songbird0 commented Aug 17, 2017

Done!

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 17, 2017

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 17, 2017

📌 Commit d6cdefc has been approved by GuillaumeGomez

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 17, 2017
@frewsxcv
Rollup merge of rust-lang#43912 - Songbird0:e0106_field_lifetimes, r=…
fa79009 
…GuillaumeGomez

E0106: field lifetimes

Hi there,

I've added an example for custom type lifetimes located in another `struct` field.

cc @GuillaumeGomez
@frewsxcv frewsxcv mentioned this pull request Aug 17, 2017
Merged
bors added a commit that referenced this pull request Aug 17, 2017
@bors
Auto merge of #43939 - frewsxcv:rollup, r=frewsxcv
59ccba9 
Rollup of 9 pull requests

- Successful merges: #43891, #43905, #43912, #43914, #43915, #43916, #43920, #43928, #43930
- Failed merges:
@bors bors merged commit d6cdefc into rust-lang:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Songbird0 @rust-highfive @GuillaumeGomez @bors @pnkfelix @aidanhs