Add proper help line for `-C inline threshold`#44548

oyvindln · 2017-09-13T18:13:10Z

Looks like someone accidentally some words when adding this.

This also remove a period on a different help line for consistency, as no options have a period.

Also remove a period on a different help line for consistency

rust-highfive · 2017-09-13T18:13:17Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

retep998 · 2017-09-13T19:44:05Z

src/librustc/session/config.rs

-        "Set the optimization fuel quota for a crate."),
+        "Set the optimization fuel quota for a crate"),
    print_fuel: Option<String> = (None, parse_opt_string, [TRACKED],
        "Make Rustc print the total optimization fuel used by a crate."),


What about this period?

Didn't notice this one. Should I remove and make them start with lowercase so that everything is the same then?

retep998 · 2017-09-13T19:44:43Z

src/librustc/session/config.rs

    linker_flavor: Option<LinkerFlavor> = (None, parse_linker_flavor, [UNTRACKED],
                                           "Linker flavor"),
    fuel: Option<(String, u64)> = (None, parse_optimization_fuel, [TRACKED],
-        "Set the optimization fuel quota for a crate."),


This is one of two options that is capitalized. All the others start with lowercase letters.

oyvindln · 2017-09-13T20:53:47Z

The options under rustc --help actually start with an uppercase letter, unlike the ones under -C/Z/W help. Maybe the help lines should start with an uppercase letter everywhere?

carols10cents · 2017-09-18T15:57:24Z

review ping @arielb1! pinging you on irc too!

arielb1 · 2017-09-18T15:59:03Z

@bors r+

bors · 2017-09-18T15:59:05Z

📌 Commit e89748e has been approved by arielb1

Add proper help line for `-C inline threshold` Looks like someone accidentally some words when adding this. This also remove a period on a different help line for consistency, as no options have a period.

Rollup of 11 pull requests - Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675 - Failed merges:

Add proper help line for inline threshold

edf1622

Also remove a period on a different help line for consistency

rust-highfive assigned arielb1 Sep 13, 2017

retep998 reviewed Sep 13, 2017

View reviewed changes

Remove the other period and start with lowercase for more consistency

e89748e

aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2017

alexcrichton mentioned this pull request Sep 18, 2017

Rollup of 11 pull requests #44678

Merged

bors added a commit that referenced this pull request Sep 18, 2017

Auto merge of #44678 - alexcrichton:rollup, r=alexcrichton

0701b37

Rollup of 11 pull requests - Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675 - Failed merges:

bors merged commit e89748e into rust-lang:master Sep 18, 2017

Manishearth mentioned this pull request Sep 21, 2017

#[doc = $expr] in macro silently fails to generate docs #44730

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add proper help line for `-C inline threshold`#44548