Conversation
GuillaumeGomez
force-pushed
the
run-button
branch
from
35b5af5 to
90ce24a
Compare
Contributor
|
Is this the right way to fix this? How'd this bug get introduced? |
Member
Author
|
Because of a position change in the |
Contributor
|
Gotcha, thanks. @bors: r+ |
Collaborator
|
📌 Commit 90ce24a has been approved by |
Member
Author
|
@bors: p=1 |
Collaborator
|
⌛ Testing commit 90ce24a with merge c6d00f65142ebe7c56a411aa3c5dfaf9e687be4f... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 18, 2017
…labnik Fix run button r? @QuietMisdreavus Before:  After:  Quite urgent.
carols10cents
added
the
S-waiting-on-bors
Member
|
@bors: retry
|
Collaborator
|
⌛ Testing commit 90ce24a with merge 0da835202813349565ca7a7f17013a96fc85759d... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 18, 2017
…labnik Fix run button r? @QuietMisdreavus Before:  After:  Quite urgent.
Member
|
@bors: retry prioritizing rollup again |
Collaborator
|
⌛ Testing commit 90ce24a with merge e856750b93231e34ec266b1c2558e4e83e43d388... |
Member
|
@bors: retry
|
Member
Author
|
Thanks @alexcrichton! |
Collaborator
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
We need it for run buttons (rust-lang#44671), but not function defs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @QuietMisdreavus
Before:
After:
Quite urgent.