Merged
Conversation
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
force-pushed
the
instance_printing
branch
from
6d0acdf to
f6703ea
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
instance_printing
branch
from
f6703ea to
8956d97
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Member
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
bjorn3
requested changes
Oct 24, 2018
src/librustc_mir/const_eval.rs
Outdated
Member
There was a problem hiding this comment.
Why trace both key and key.value.instance?
Contributor
Author
There was a problem hiding this comment.
Because the printing via Display of the instance goes through the code that was ICEing here before
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
oli-obk
force-pushed
the
instance_printing
branch
from
8956d97 to
8890a94
Compare
Member
|
You just rebased, right? So we can r=davidtwco again? Cc @davidtwco |
Member
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
oli-obk
force-pushed
the
instance_printing
branch
from
8890a94 to
5a48f20
Compare
Contributor
Author
|
rebased again, and added a comment about what's going on |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 5a48f20 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 5a48f20 with merge 432e9f370d86b3212d1a153c263c946e979d9314... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
|
@bors retry |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 28, 2018
Impl items have generics
bors
added a commit
that referenced
this pull request
Oct 28, 2018
Rollup of 11 pull requests Successful merges: - #55148 (Implement FromStr for PathBuf) - #55185 (path suggestions in Rust 2018 should point out the change in semantics) - #55191 (Fix sub-variant doc display) - #55199 (Impl items have generics) - #55244 (Don't rerun MIR passes when inlining) - #55252 (Add MaybeUninit::new) - #55257 (Allow extern statics with an extern type) - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…) - #55406 (Update string.rs) - #55412 (Fix an ICE in the min_const_fn analysis) - #55421 (Add ManuallyDrop::take)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.