Merged
Conversation
Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
Sometimes it *is* initialized!
When inlining a function using the Mir inliner, we shouldn't rerun the various Mir passes on it because the Mir has already been lowered and that wil break various early Mir passes. The issue in rust-lang#50411 is that we've inlined a function with promotions whose Mir has already been lowered. The promotions are then copied into the local function and we begin to run passes on their lowered Mir which causes the ICE. Fixes rust-lang#50411
This can be obtained via the `$mir_phase` value.
As suggested in the feedback for rust-lang#55244. When I replaced the macro with a function, rustc started complaining that there were two unused functions so I also removed those.
remove unused variable i in example String::with_capacity()
This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.
Implement FromStr for PathBuf Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
…uietMisdreavus Fix sub-variant doc display Fixes rust-lang#54758. <img width="1440" alt="screen shot 2018-10-19 at 01 34 11" src="https://user-images.githubusercontent.com/3050060/47189939-43481d00-d33f-11e8-868f-cf479fc79e62.png"> r? @QuietMisdreavus
…akis Don't rerun MIR passes when inlining Fixes rust-lang#50411 r? @nikomatsakis I updated your commit message with additional details. Let me know if any of that is incorrect. I also added the appropriate `compile-flags` directive to the test. Thanks for you help on this! cc @RalfJung related to your PR rust-lang#55086
Add MaybeUninit::new Sometimes it *is* initialized!
Member
Author
|
@bors r+ p=9 |
Collaborator
|
📌 Commit bfe15b59c0c20173493bbaf82b2756358b679b6e has been approved by |
bors
added
the
S-waiting-on-bors
Member
Author
|
@bors r+ Removed #55262 (high risk, maybe causing failure of #55425 (comment)) |
Collaborator
|
📌 Commit a6d97281a5481db835e101db3dc93bd5dff13469 has been approved by |
Collaborator
|
⌛ Testing commit a6d97281a5481db835e101db3dc93bd5dff13469 with merge 8a21b8e099d1daf8afd39fcbd7106f4ef4fabaf4... |
Member
Author
|
@bors treeclosed=1 Travis jobs are not starting due to https://www.traviscistatus.com/incidents/7k1r5btfg45m |
Member
|
Travis incident is resolved. |
Collaborator
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Remove unnecessary mut in iterator.find_map documentation example, R… Relates to rust-lang#49098 Removes a mut that could induce newcomers to put a mut in their code that the compiler would comply about. https://github.com/rust-lang/rust/pull/49098/files#r227422388
Update string.rs remove unused variable i in example String::with_capacity()
Fix an ICE in the min_const_fn analysis fixes rust-lang#55395 cc @Centril
Add ManuallyDrop::take Tracking issue: rust-lang#55422 Proposed in this form in https://internals.rust-lang.org/t/mini-rfc-manuallydrop-take/8679, see that thread for some history. A small convenience wrapper for `ManuallyDrop` that makes a pattern (taking ownership of the contained data in drop) more obvious.
path suggestions in Rust 2018 should point out the change in semantics Fixes rust-lang#55130. This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.
Allow extern statics with an extern type Fixes rust-lang#55239
Impl items have generics
Collaborator
|
📌 Commit db4e77c has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Oct 28, 2018
Rollup of 11 pull requests Successful merges: - #55148 (Implement FromStr for PathBuf) - #55185 (path suggestions in Rust 2018 should point out the change in semantics) - #55191 (Fix sub-variant doc display) - #55199 (Impl items have generics) - #55244 (Don't rerun MIR passes when inlining) - #55252 (Add MaybeUninit::new) - #55257 (Allow extern statics with an extern type) - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…) - #55406 (Update string.rs) - #55412 (Fix an ICE in the min_const_fn analysis) - #55421 (Add ManuallyDrop::take)
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges: