Ensure that the argument to `static_assert` is a `bool`#55945

oli-obk · 2018-11-14T09:59:26Z

rust-highfive · 2018-11-14T09:59:37Z

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2018-11-14T10:04:27Z

src/librustc_data_structures/macros.rs

You could use #[allow_internal_unstable] instead, maybe?
Also, has the const _ = ...; proposal been implemented?

Also, has the const _ = ...; proposal been implemented?

It has been implemented, but it does not cope well with allow_internal_unstable, because the crate using static_assert won't have the feature for _ items enabled, thus causing an error about item with name _ being declared multiple times

I'm very confused, how could that even happen?!

I don't know, I presume it's because we now do have multiple items with the name _, but the multiple items with same name check doesn't know about allow_internal_unstable and thus assumes the relevant feature gate (for _ names) isn't active.

But the implementation should be using gensym so that should be impossible?

@oli-obk No, because that won't preserve the association. Anyway, gensyms are just an implementation hack, you don't actually need a name for these items.

I can refactor AST and HIR to have Option<Symbol> for their items' names

That seems overkill for now, and also, we can move this into an issue and land a simpler version of this patch.

by simpler you mean keeping the actual names for the assert items?

rust-highfive · 2018-11-15T15:09:46Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:012f6537:start=1542293740011405310,finish=1542293794140951248,duration=54129545938
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:06:59]    Compiling proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:07:09]    Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[00:12:44]    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
[00:12:44]    Compiling rustc_allocator v0.0.0 (/checkout/src/librustc_allocator)
[00:12:45] error[E0428]: the name `_` is defined multiple times
[00:12:45]   |
[00:12:45]   = note: `_` must be defined only once in the value namespace of this module
[00:12:45] 
[00:12:45] error[E0428]: the name `_` is defined multiple times
[00:12:45]   |
[00:12:45]   = note: `_` must be defined only once in the value namespace of this module
[00:12:45] 
[00:12:45] error[E0428]: the name `_` is defined multiple times
[00:12:45]   |
[00:12:45]   = note: `_` must be defined only once in the value namespace of this module
[00:12:45] error: aborting due to previous error
[00:12:45] 
[00:12:45] For more information about this error, try `rustc --explain E0428`.
[00:12:45] error: Could not compile `rustc_incremental`.
---
[00:12:58] 
[00:12:58] To learn more, run the command again with --verbose.
[00:12:58] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:12:58] expected success, got: exit code: 101
[00:12:58] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1101:9
[00:12:58] travis_fold:end:stage0-rustc

[00:12:58] travis_time:end:stage0-rustc:start=1542294094969952935,finish=1542294582869087564,duration=487899134629


[00:12:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:12:58] Build completed unsuccessfully in 0:09:13
[00:12:58] Makefile:28: recipe for target 'all' failed
[00:12:58] make: *** [all] Error 1

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

michaelwoerister · 2018-11-16T09:54:05Z

@oli-obk Looks pretty cool, if you can get it to work :)

michaelwoerister · 2018-11-22T12:00:36Z

@bors r+

bors · 2018-11-22T12:00:37Z

📌 Commit 65e6fdb has been approved by michaelwoerister

@eddyb

…ichaelwoerister Ensure that the argument to `static_assert` is a `bool` cc @eddyb

@ghost

Rollup of 14 pull requests Successful merges: - #55767 (Disable some pretty-printers when gdb is rust-enabled) - #55838 (Fix #[cfg] for step impl on ranges) - #55869 (Add std::iter::unfold) - #55945 (Ensure that the argument to `static_assert` is a `bool`) - #56022 (When popping in CTFE, perform validation before jumping to next statement to have a better span for the error) - #56048 (Add rustc_codegen_ssa to sysroot) - #56091 (Fix json output in the self-profiler) - #56097 (Fix invalid bitcast taking bool out of a union represented as a scalar) - #56116 (ci: Download clang/lldb from tarballs) - #56120 (Add unstable Literal::subspan().) - #56154 (Pass additional linker flags when targeting Fuchsia) - #56162 (std::str Adapt documentation to reality) - #56163 ([master] Backport 1.30.1 release notes) - #56168 (Fix the tracking issue for hash_raw_entry) Failed merges: r? @ghost

rust-highfive assigned michaelwoerister Nov 14, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2018

eddyb reviewed Nov 14, 2018

View reviewed changes

petrochenkov self-assigned this Nov 14, 2018

oli-obk force-pushed the static_assert_arg_type branch from a9018ea to d47b66b Compare November 15, 2018 14:54

petrochenkov removed their assignment Nov 16, 2018

Ensure that the static_assert! argument is a bool

65e6fdb

oli-obk force-pushed the static_assert_arg_type branch from d47b66b to 65e6fdb Compare November 16, 2018 10:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Nov 23, 2018

Rollup merge of rust-lang#55945 - oli-obk:static_assert_arg_type, r=m…

12f6a42

…ichaelwoerister Ensure that the argument to `static_assert` is a `bool` cc @eddyb

kennytm mentioned this pull request Nov 23, 2018

Rollup of 14 pull requests #56186

Merged

bors merged commit 65e6fdb into rust-lang:master Nov 23, 2018

oli-obk deleted the static_assert_arg_type branch June 15, 2020 15:29

Uh oh!

Conversation

oli-obk commented Nov 14, 2018

Uh oh!

rust-highfive commented Nov 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oli-obk Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Nov 15, 2018

Uh oh!

michaelwoerister commented Nov 16, 2018

Uh oh!

michaelwoerister commented Nov 22, 2018

Uh oh!

bors commented Nov 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

oli-obk Nov 16, 2018 •

edited

Loading