Add rustc_codegen_ssa to sysroot#56048
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Please cc me on PRs related to I did this on purpose. It allows only codegen backends to be recompiled, without impacting the driver. I think we need better rustbuild integration to ship dylibs or rlibs for cc @rust-lang/compiler @Mark-Simulacrum @alexcrichton |
eddyb
added
I-nominated
T-compiler
|
It shouldn't be too hard to wire up rustbuild to copy the ssa dylib into the sysroot; I agree that such a change would be preferable here. I can probably get some instructions up if that would be helpful, @bjorn3 - loosely I'd start looking in src/bootstrap/compiler.rs. |
|
I don't personally have an opinion on whether or not this should go in the sysroot. If it should then this PR looks best to me. |
|
Actually, looking at this a bit more, I think I misunderstood the specific intent here, and now agree that this PR makes more sense than rustbuild modifications as a solution to this problem. We can maybe move the specific dependency edge to src/rustc to avoid rebuilding driver (or shift rustbuild around to use some other "fake" root crate). |
Will do it next time.
Done |
|
@eddyb I think the latest changes should essentially resolve your concerns with regards to compile times; as such I'm r=me on this change since I think it does the sort of "minimal" changeset to make this happen. |
|
📌 Commit 040ffba76bf8cd02e8fa5b40af872d52ae54c30a has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #53586) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
bjorn3
force-pushed
the
cg_ssa_sysroot
branch
from
040ffba to
60e4158
Compare
|
Rebased |
|
@bors r+ |
|
📌 Commit 60e4158 has been approved by |
bors
added
S-waiting-on-bors
Add rustc_codegen_ssa to sysroot Outside of rustc you are currently unable to use it. r? @nikomatsakis (because you r+'ed rust-lang#55627)
Rollup of 14 pull requests Successful merges: - #55767 (Disable some pretty-printers when gdb is rust-enabled) - #55838 (Fix #[cfg] for step impl on ranges) - #55869 (Add std::iter::unfold) - #55945 (Ensure that the argument to `static_assert` is a `bool`) - #56022 (When popping in CTFE, perform validation before jumping to next statement to have a better span for the error) - #56048 (Add rustc_codegen_ssa to sysroot) - #56091 (Fix json output in the self-profiler) - #56097 (Fix invalid bitcast taking bool out of a union represented as a scalar) - #56116 (ci: Download clang/lldb from tarballs) - #56120 (Add unstable Literal::subspan().) - #56154 (Pass additional linker flags when targeting Fuchsia) - #56162 (std::str Adapt documentation to reality) - #56163 ([master] Backport 1.30.1 release notes) - #56168 (Fix the tracking issue for hash_raw_entry) Failed merges: r? @ghost
7 participants
Outside of rustc you are currently unable to use it.
r? @nikomatsakis (because you r+'ed #55627)